From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 560C97ED4 for ; Thu, 27 Apr 2017 09:34:23 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 00:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="1161577454" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2017 00:34:22 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 00:34:22 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 00:34:21 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 15:34:19 +0800 From: "Tan, Jianfeng" To: "Michael S. Tsirkin" CC: Yuanhan Liu , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "thomas@monjalon.net" Thread-Topic: [PATCH 2/3] net/virtio: clean up LSC setting Thread-Index: AQHSvkjlGQB50Zos5E+qJHVB6nfh0KHWmlaAgACHunCAABnuAIABmH+g Date: Thu, 27 Apr 2017 07:34:18 +0000 Message-ID: References: <1493182371-34295-1-git-send-email-jianfeng.tan@intel.com> <1493182371-34295-3-git-send-email-jianfeng.tan@intel.com> <20170426053235.GF11512@yliu-dev.sh.intel.com> <20170426181041-mutt-send-email-mst@kernel.org> In-Reply-To: <20170426181041-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 07:34:24 -0000 > -----Original Message----- > From: Michael S. Tsirkin [mailto:mst@redhat.com] > Sent: Wednesday, April 26, 2017 11:11 PM > To: Tan, Jianfeng > Cc: Yuanhan Liu; dev@dpdk.org; maxime.coquelin@redhat.com; > thomas@monjalon.net > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting >=20 > On Wed, Apr 26, 2017 at 05:44:05AM +0000, Tan, Jianfeng wrote: > > > > > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > Sent: Wednesday, April 26, 2017 1:33 PM > > > To: Tan, Jianfeng > > > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > thomas@monjalon.net > > > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting > > > > > > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote: > > > > Clean up LSC setting: > > > > > > Firstly, this patch does two things. There should be two patches. > > > > I just merged them into one to adapt to the name of "clean up" :-) > > > > > > > > > - LSC flag is set in several places, but only the last one takes > > > > effect; so we just keep the last one. > > > > - As we already change to use capability list to detect MSI-X, re= move > > > > the redundant MSI-X detection in legacy devices. > > > > > > However, there is no capability list for legacy device. > > > > When I try legacy device on QEMU (disable-modern=3Dtrue), I did detect > MSI-X capability. So does virtio spec mean legacy devices do not have > vendor-specific capability list? > > > > Thanks, > > Jianfeng >=20 > Yes, as far as I know legacy devices don't have vendor-specific > capability lists. >=20 > -- > MST Thank you to confirm this, Michael. Thanks, Jianfeng