From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0C8F4968 for ; Tue, 19 Sep 2017 08:01:18 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 23:01:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,416,1500966000"; d="scan'208";a="1196595713" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 18 Sep 2017 23:01:17 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Sep 2017 23:01:17 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Sep 2017 23:01:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Tue, 19 Sep 2017 14:01:14 +0800 From: "Tan, Jianfeng" To: "De Lara Guarch, Pablo" , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus Thread-Index: AQHTHYYOY/pQthauukSiTeZkGfg2GqKazYsAgAEpBYCAHjAtAIABqN5Q Date: Tue, 19 Sep 2017 06:01:14 +0000 Message-ID: References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-5-git-send-email-jianfeng.tan@intel.com> <20170829130430.GO8124@bidouze.vm.6wind.com> <8d8e053d-28c3-7cf5-f906-8fa1159187ca@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 06:01:19 -0000 Hi Pablo > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:48 PM > To: Tan, Jianfeng; Ga=EBtan Rivet > Cc: dev@dpdk.org; Richardson, Bruce; Ananyev, Konstantin; > thomas@monjalon.net; yliu@fridaylinux.org; maxime.coquelin@redhat.com; > mtetsuyah@gmail.com; Yigit, Ferruh > Subject: RE: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus >=20 >=20 ... > > > Let's say the cryptodev lib must be updated. > > > I understand the need to move rte_cryptodev_vdev.h outside > > > librte_cryptodev, but I guess this exposes the vdev bus to ABI / API > > > instability due to a third-party subsystem? > > > > Thank you for bringing up this question. I really don't want to move > > these crypto-specific files into bus/vdev/. It's just some helper > > functions to be called by crypto vdev drivers. And what's more, the onl= y > > dependence on vdev is that the API rte_cryptodev_vdev_pmd_init() has a > > parameter of struct rte_vdev_device, which is totally not necessary, as > > it only needs a struct rte_device parameter. > > > > In all, I'd prefer to change this specific API and move those > > crypto-specific files back to lib/librte_crypto (just like ether dev an= d > > eventdev); but it needs API change announcement. > > > > Any thoughts? >=20 > I think we should keep this API in cryptodev. It looks strange to have so= me > Crypto specific functions in a file like this that should contain generic= vdev > functions. OK, I'll try to put those files back, see if possible to add a dependency o= n librte_bus_vdev in lib_cryptodev. ... >=20 > Btw, for future times, strip out all the text where there are no comments= , > so it is easier to review by others. Thank you for the reminder. Thanks, Jianfeng=20 >=20 > Thanks, > Pablo