From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 009881BBAD for ; Fri, 27 Oct 2017 10:19:28 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 27 Oct 2017 01:19:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,304,1505804400"; d="scan'208";a="168307630" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 27 Oct 2017 01:19:27 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Oct 2017 01:19:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Oct 2017 01:19:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Fri, 27 Oct 2017 16:19:25 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon CC: "dev@dpdk.org" , "jblunck@infradead.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "De Lara Guarch, Pablo" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" Thread-Topic: [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus Thread-Index: AQHTTsAEK9urOAk3yUOh4ZBQsd+SAqL2zooAgACJlKA= Date: Fri, 27 Oct 2017 08:19:25 +0000 Message-ID: References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1509066419-117099-1-git-send-email-jianfeng.tan@intel.com> <1509066419-117099-4-git-send-email-jianfeng.tan@intel.com> <1536098.KmeRH1tTdf@xps> In-Reply-To: <1536098.KmeRH1tTdf@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 08:19:29 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, October 27, 2017 3:56 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblunck@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; yliu@fridaylinux.org; > maxime.coquelin@redhat.com; mtetsuyah@gmail.com; Yigit, Ferruh > Subject: Re: [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus >=20 > 27/10/2017 03:06, Jianfeng Tan: > > --- /dev/null > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > @@ -0,0 +1,8 @@ > > +DPDK_17.11 { > > + global: > > + > > + rte_vdev_init; > > + rte_vdev_register; > > + rte_vdev_uninit; > > + rte_vdev_unregister; > > +}; >=20 > It should not be needed to export the driver ops. rte_vdev_register/unregister are needed by vdev PMDs, which are needed to e= xport, isn't it? And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use= rte_eal_dev_attach()/detach()? >=20 > Please can you try to make it private? Even we want to make it private, I think it needs deprecation notice, which= we can further improved for the next release? Thanks, Jianfeng