From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2AE2C1B21F for ; Wed, 1 Nov 2017 03:17:23 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2017 19:17:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,326,1505804400"; d="scan'208";a="167628614" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 31 Oct 2017 19:17:22 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Oct 2017 19:17:22 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Oct 2017 19:17:21 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 1 Nov 2017 10:17:17 +0800 From: "Tan, Jianfeng" To: "Yigit, Ferruh" , Thomas Monjalon , "Richardson, Bruce" , "Gonzalez Monroy, Sergio" CC: "dev@dpdk.org" , Santosh Shukla Thread-Topic: [PATCH] eal: disable IOVA mode detection by default Thread-Index: AQHTUq3QHxnmHXSlJUO0oYr92A9MLaL+xIQA Date: Wed, 1 Nov 2017 02:17:16 +0000 Message-ID: References: <20171101010726.17781-1-ferruh.yigit@intel.com> In-Reply-To: <20171101010726.17781-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 02:17:24 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, November 1, 2017 9:07 AM > To: Thomas Monjalon; Richardson, Bruce; Gonzalez Monroy, Sergio > Cc: dev@dpdk.org; Yigit, Ferruh; Tan, Jianfeng; Santosh Shukla > Subject: [PATCH] eal: disable IOVA mode detection by default >=20 > Fix kernel crash with KNI because KNI requires physical addresses. >=20 > A config option introduced to disable IOVA mode detection and to set it > to physical address by default. Disabling config option will enable IOVA > mode detection. >=20 > When there is no intension to use KNI, it is safe to enable detection. >=20 > Config option disable IOVA mode detection by default to be sure only who > is aware of result enable it. >=20 > Fixes: 72d013644bd6 ("mem: honor IOVA mode in malloc virt2phy") >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Jianfeng Tan > Cc: Santosh Shukla > Cc: Thomas Monjalon Refer to how vhost-kernel works, we may leverage a memory region table to d= o the translation. The bad side is it's less efficient than current phys_to= _virt. Another side, we did not check the result of phys_to_virt, that's why kerne= l crashes. Thanks, Jianfeng