From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 97C931B2BF for ; Wed, 1 Nov 2017 09:53:24 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 01 Nov 2017 01:53:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,327,1505804400"; d="scan'208";a="169853104" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 01 Nov 2017 01:53:22 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 01:53:21 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 01:53:22 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Wed, 1 Nov 2017 16:53:19 +0800 From: "Tan, Jianfeng" To: Jerin Jacob CC: "Yigit, Ferruh" , Thomas Monjalon , "Richardson, Bruce" , "Gonzalez Monroy, Sergio" , "dev@dpdk.org" , Santosh Shukla Thread-Topic: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default Thread-Index: AQHTUq3QHxnmHXSlJUO0oYr92A9MLaL+YRsAgAAmrgCAAAlJAIAAkoqA//+HOQCAAIeQYA== Date: Wed, 1 Nov 2017 08:53:19 +0000 Message-ID: References: <20171101010726.17781-1-ferruh.yigit@intel.com> <20171101040251.GA13569@jerin> <80719d01-7859-e6ac-ee1e-964a04357098@intel.com> <20171101065431.GA25152@jerin> <20171101082642.GA30967@jerin> In-Reply-To: <20171101082642.GA30967@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 08:53:25 -0000 > -----Original Message----- ... > > > > > Regarding the KNI crash, it can be avoid by first checking the exitin= g > > > mode(rte_eal_iova_mode()). i.e since legacy driver like KNI need real > > > physical address to work "now", it can grace full exit on the init ti= me if > > > mode =3D=3D IOVA_VA; > > > > For the KNI crash, do we really need to correct the case: make those P= MDs > > (requires IOVA_VA) also work well with KNI? > > - If no, we just need to report RTE_PCI_DRV_IOVA_AS_VA smartly. > > - If yes, we shall make KNI work with VA. >=20 > I would say "yes". But for this immediate release, I would say "no". Ferruh, if you also agree on "no" for now, we might fix it like this: For PMDs like ixgbe/i40e/..., we detect if phys_addrs_available to decide R= TE_PCI_DRV_IOVA_AS_VA in a RTE_INIT function. How do you think of that? Thanks, Jianfeng