From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 635AB5F59 for ; Wed, 21 Mar 2018 03:28:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 19:28:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,338,1517904000"; d="scan'208";a="26686119" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 20 Mar 2018 19:28:26 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 19:28:26 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 19:28:25 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Wed, 21 Mar 2018 10:28:23 +0800 From: "Tan, Jianfeng" To: "Pattan, Reshma" , "dev@dpdk.org" Thread-Topic: [PATCH] pdump: change to use generic multi-process channel Thread-Index: AQHTs8ndG6L72y5Ol0+dtwgmKVSfbqPY5dyAgAEjEiA= Date: Wed, 21 Mar 2018 02:28:23 +0000 Message-ID: References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2B82D6@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2B82D6@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 02:28:28 -0000 Thank you for the comments! > -----Original Message----- > From: Pattan, Reshma > Sent: Wednesday, March 21, 2018 12:38 AM > To: Tan, Jianfeng; dev@dpdk.org > Subject: RE: [PATCH] pdump: change to use generic multi-process channel >=20 > Hi, >=20 > > -----Original Message----- > > From: Tan, Jianfeng > > Sent: Sunday, March 4, 2018 3:04 PM > > To: dev@dpdk.org > > Cc: Tan, Jianfeng ; Pattan, Reshma > > > > Subject: [PATCH] pdump: change to use generic multi-process channel > > > > The original code replies on the private channel for primary and second= ary > > communication. Change to use the generic multi-process channel. > > > > Note with this change, dpdk-pdump will be not compatible with old versi= on > > DPDK applications. > > >=20 > Is this the correct time to make this change? As I see the rte_mp APIs ar= e still > in experimental stage? > If you wish to change them, >=20 > 1) I feel ABI breakage has to be addressed first for change in rte_pdump= _init() .=20 > 2)ABI notice for removal of the rte_pdump_set_socket_dir() and then remo= ve it completely . This patch itself does not break any ABI. It just puts parameters of rte_pd= ump_init() not used. And make rte_pdump_set_socket_dir() as a dummy functio= n. > 3)Need to do cleanup of the code app/dpdk-pdump. Yes, I understand it's a normal process to announce deprecation firstly, an= d then do the change. But here is the thing, with generic mp introduced, we will not be compatibl= e with DPDK versions. So we want to unify the use of generic mp channel in this release for vfio,= pdump, vdev, memory rework. And in fact, ABI/API changes could be delayed to later releases. > 4)After all the changes we need to make sure dpdk-pdump works fine > without breaking the functionality, validation team should be able to hel= p. I have done a simple test of pdump. Can you suggest where can I get the com= prehensive test cases? > 5)Replace strcpy with snprintf. Will do. Thanks, Jianfeng >=20 > Thanks, > Reshma >=20