From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A7FFC1B021 for ; Wed, 28 Mar 2018 04:09:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 19:09:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,369,1517904000"; d="scan'208";a="215309846" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 27 Mar 2018 19:09:30 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 19:09:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 19:09:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Wed, 28 Mar 2018 10:08:57 +0800 From: "Tan, Jianfeng" To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC Thread-Index: AQHTxdPlt82HbUQG6UeHsDU75C45u6PjwQYAgAEUgMA= Date: Wed, 28 Mar 2018 02:08:56 +0000 Message-ID: References: <5d94df0912159b96aa71da5249598bd8c744a198.1522159146.git.anatoly.burakov@intel.com> <3396888.LEadjR7LpM@xps> In-Reply-To: <3396888.LEadjR7LpM@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 02:09:33 -0000 Hi Thomas , > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, March 28, 2018 12:34 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Tan, Jianfeng; Ananyev, Konstantin; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API = to > DPDK IPC >=20 > 27/03/2018 15:59, Anatoly Burakov: > > Under the hood, we create a separate thread to deal with replies to > > asynchronous requests, that will just wait to be notified by the > > main thread, or woken up on a timer. >=20 > I really don't like that a library is creating a thread. > We don't even know where the thread is created (which core). > Can it be a rte_service? or in the interrupt thread? Agree that we'd better not adding so many threads in a library. I was considering to merge all the threads into the interrupt thread, howev= er, we don't have an interrupt thread in freebsd. Further, we don't impleme= nt alarm API in freebsd. That's why I tend to current implementation, and o= ptimize it later. For rte_service, it may be not a good idea to reply on it as it needs expli= cit API calls to setup. >=20 >=20 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -225,6 +225,7 @@ EXPERIMENTAL { > > rte_mp_action_unregister; > > rte_mp_sendmsg; > > rte_mp_request; > > + rte_mp_request_async; >=20 > So there is rte_mp_request and rte_mp_request_async? > You should rename rte_mp_request, I guess. +1. Thanks, Jianfeng >=20 > > rte_mp_reply; > > rte_service_attr_get; > > rte_service_attr_reset_all; >=20 >=20 >=20 >=20