Re: [dpdk-dev] [PATCH v7 2/3] eal: rename mp_request to mp_request_sync

["Tan, Jianfeng" <jianfeng.tan@intel.com>]

> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Sunday, April 1, 2018 1:06 AM
> To: dev@dpdk.org
> Cc: Tan, Jianfeng; Ananyev, Konstantin; thomas@monjalon.net
> Subject: [PATCH v7 2/3] eal: rename mp_request to mp_request_sync
> 
> Rename rte_mp_request to rte_mp_request_sync to indicate
> that this request will be done synchronously (as opposed to
> asynchronous request, which comes in next patch).
> 
> Also, fix alphabetical ordering for .map file.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>

Thanks!

> ---
> 
> Notes:
>     v7:
>     - Added this patch
> 
>  lib/librte_eal/common/eal_common_proc.c | 2 +-
>  lib/librte_eal/common/include/rte_eal.h | 2 +-
>  lib/librte_eal/rte_eal_version.map      | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_proc.c
> b/lib/librte_eal/common/eal_common_proc.c
> index 52b6ab2..b704f5a 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -674,7 +674,7 @@ mp_request_one(const char *dst, struct rte_mp_msg
> *req,
>  }
> 
>  int __rte_experimental
> -rte_mp_request(struct rte_mp_msg *req, struct rte_mp_reply *reply,
> +rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply
> *reply,
>  		const struct timespec *ts)
>  {
>  	int dir_fd, ret = 0;
> diff --git a/lib/librte_eal/common/include/rte_eal.h
> b/lib/librte_eal/common/include/rte_eal.h
> index 044474e..d1cc89e 100644
> --- a/lib/librte_eal/common/include/rte_eal.h
> +++ b/lib/librte_eal/common/include/rte_eal.h
> @@ -314,7 +314,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg);
>   *  - On failure, return -1, and the reason will be stored in rte_errno.
>   */
>  int __rte_experimental
> -rte_mp_request(struct rte_mp_msg *req, struct rte_mp_reply *reply,
> +rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply
> *reply,
>  	       const struct timespec *ts);
> 
>  /**
> diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> index d123602..7b66c73 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -223,9 +223,9 @@ EXPERIMENTAL {
>  	rte_eal_mbuf_user_pool_ops;
>  	rte_mp_action_register;
>  	rte_mp_action_unregister;
> -	rte_mp_sendmsg;
> -	rte_mp_request;
>  	rte_mp_reply;
> +	rte_mp_request_sync;
> +	rte_mp_sendmsg;
>  	rte_service_attr_get;
>  	rte_service_attr_reset_all;
>  	rte_service_component_register;
> --
> 2.7.4