From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 881F51B866
for <dev@dpdk.org>; Wed, 4 Apr 2018 03:48:01 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
03 Apr 2018 18:48:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,404,1517904000"; d="scan'208";a="43198590"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
by fmsmga004.fm.intel.com with ESMTP; 03 Apr 2018 18:48:00 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 3 Apr 2018 18:47:59 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 3 Apr 2018 18:47:59 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by
SHSMSX151.ccr.corp.intel.com ([169.254.3.163]) with mapi id 14.03.0319.002;
Wed, 4 Apr 2018 09:47:57 +0800
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "stephen@networkplumber.org"
<stephen@networkplumber.org>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "Wu, Jingjing"
<jingjing.wu@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
"motih@mellanox.com" <motih@mellanox.com>, "Van Haaren, Harry"
<harry.van.haaren@intel.com>
CC: "jblunck@infradead.org" <jblunck@infradead.org>, "shreyansh.jain@nxp.com"
<shreyansh.jain@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin"
<helin.zhang@intel.com>
Thread-Topic: [PATCH V18 1/4] eal: add device event handle in interrupt thread
Thread-Index: AQHTyzdxIqrrr5A2N0CH/wdM5L+dSqPv1vJQ
Date: Wed, 4 Apr 2018 01:47:56 +0000
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E36514C6F9E@SHSMSX103.ccr.corp.intel.com>
References: <1522339205-27698-5-git-send-email-jia.guo@intel.com>
<1522751639-2315-1-git-send-email-jia.guo@intel.com>
<1522751639-2315-2-git-send-email-jia.guo@intel.com>
In-Reply-To: <1522751639-2315-2-git-send-email-jia.guo@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH V18 1/4] eal: add device event handle in
interrupt thread
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 01:48:02 -0000
> -----Original Message-----
> From: Guo, Jia
> Sent: Tuesday, April 3, 2018 6:34 PM
> To: stephen@networkplumber.org; Richardson, Bruce; Yigit, Ferruh;
> Ananyev, Konstantin; gaetan.rivet@6wind.com; Wu, Jingjing;
> thomas@monjalon.net; motih@mellanox.com; Van Haaren, Harry; Tan,
> Jianfeng
> Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo,
> Jia; Zhang, Helin
> Subject: [PATCH V18 1/4] eal: add device event handle in interrupt thread
>=20
> Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for
> device event interrupt monitor.
>=20
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
After fixing a typo below, you can carry my:
Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> v18->v17:
> no change.
> ---
> lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +
> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +++++-
> test/test/test_interrupts.c | 39 ++++++++++++++++=
++++--
> 3 files changed, 48 insertions(+), 3 deletions(-)
>=20
> diff --git a/lib/librte_eal/common/include/rte_eal_interrupts.h
> b/lib/librte_eal/common/include/rte_eal_interrupts.h
> index 3f792a9..6eb4932 100644
> --- a/lib/librte_eal/common/include/rte_eal_interrupts.h
> +++ b/lib/librte_eal/common/include/rte_eal_interrupts.h
> @@ -34,6 +34,7 @@ enum rte_intr_handle_type {
> RTE_INTR_HANDLE_ALARM, /**< alarm handle */
> RTE_INTR_HANDLE_EXT, /**< external handler */
> RTE_INTR_HANDLE_VDEV, /**< virtual device */
> + RTE_INTR_HANDLE_DEV_EVENT, /**< device event handle */
> RTE_INTR_HANDLE_MAX /**< count of elements */
> };
>=20
> diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
> b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
> index f86f22f..58e9328 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
> @@ -559,6 +559,9 @@ rte_intr_enable(const struct rte_intr_handle
> *intr_handle)
> return -1;
> break;
> #endif
> + /* not used at this moment */
> + case RTE_INTR_HANDLE_DEV_EVENT:
> + return -1;
> /* unknown handle type */
> default:
> RTE_LOG(ERR, EAL,
> @@ -606,6 +609,9 @@ rte_intr_disable(const struct rte_intr_handle
> *intr_handle)
> return -1;
> break;
> #endif
> + /* not used at this moment */
> + case RTE_INTR_HANDLE_DEV_EVENT:
> + return -1;
> /* unknown handle type */
> default:
> RTE_LOG(ERR, EAL,
> @@ -674,7 +680,10 @@ eal_intr_process_interrupts(struct epoll_event
> *events, int nfds)
> bytes_read =3D 0;
> call =3D true;
> break;
> -
> + case RTE_INTR_HANDLE_DEV_EVENT:
> + bytes_read =3D 0;
> + call =3D true;
> + break;
> default:
> bytes_read =3D 1;
> break;
> diff --git a/test/test/test_interrupts.c b/test/test/test_interrupts.c
> index 31a70a0..7f4f1b4 100644
> --- a/test/test/test_interrupts.c
> +++ b/test/test/test_interrupts.c
> @@ -20,6 +20,7 @@ enum test_interrupt_handle_type {
> TEST_INTERRUPT_HANDLE_VALID,
> TEST_INTERRUPT_HANDLE_VALID_UIO,
> TEST_INTERRUPT_HANDLE_VALID_ALARM,
> + TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT,
> TEST_INTERRUPT_HANDLE_CASE1,
> TEST_INTERRUPT_HANDLE_MAX
> };
> @@ -80,6 +81,10 @@ test_interrupt_init(void)
> intr_handles[TEST_INTERRUPT_HANDLE_VALID_ALARM].type =3D
> RTE_INTR_HANDLE_ALARM;
>=20
> + intr_handles[TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT].fd =3D
> pfds.readfd;
> + intr_handles[TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT].type =3D
> + RTE_INTR_HANDLE_DEV_EVENT;
> +
> intr_handles[TEST_INTERRUPT_HANDLE_CASE1].fd =3D pfds.writefd;
> intr_handles[TEST_INTERRUPT_HANDLE_CASE1].type =3D
> RTE_INTR_HANDLE_UIO;
>=20
> @@ -250,6 +255,14 @@ test_interrupt_enable(void)
> return -1;
> }
>=20
> + /* check with specific valid intr_handle */
> + test_intr_handle =3D
> intr_handles[TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT];
> + if (rte_intr_enable(&test_intr_handle) =3D=3D 0) {
> + printf("unexpectedly enable a specific intr_handle "
> + "successfully\n");
> + return -1;
> + }
> +
> /* check with valid handler and its type */
> test_intr_handle =3D intr_handles[TEST_INTERRUPT_HANDLE_CASE1];
> if (rte_intr_enable(&test_intr_handle) < 0) {
> @@ -306,6 +319,14 @@ test_interrupt_disable(void)
> return -1;
> }
>=20
> + /* check with specific valid intr_handle */
> + test_intr_handle =3D
> intr_handles[TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT];
> + if (rte_intr_disable(&test_intr_handle) =3D=3D 0) {
> + printf("unexpectedly disable a specific intr_handle "
> + "successfully\n");
> + return -1;
> + }
> +
> /* check with valid handler and its type */
> test_intr_handle =3D intr_handles[TEST_INTERRUPT_HANDLE_CASE1];
> if (rte_intr_disable(&test_intr_handle) < 0) {
> @@ -393,9 +414,17 @@ test_interrupt(void)
> goto out;
> }
>=20
> + printf("Check valid device event interrupt full path\n");
> + if (test_interrupt_full_path_check(
> + TEST_INTERRUPT_HANDLE_VALID_DEVICE_EVENT) < 0) {
Here is a typo which brings below compile error:
dpdk/test/test/test_interrupts.c:419:3: error: 'TEST_INTERRUPT_HANDLE_VALI=
D_DEVICE_EVENT' undeclared (first use in this function)
TEST_INTERRUPT_HANDLE_VALID_DEVICE_EVENT) < 0) {
Thanks,
Jianfeng
> + printf("failure occurred during checking valid device event "
> + "interrupt full path\n");
> + goto out;
> + }
> +
> printf("Check valid alarm interrupt full path\n");
> - if
> (test_interrupt_full_path_check(TEST_INTERRUPT_HANDLE_VALID_ALARM)
> - < 0) {
> + if (test_interrupt_full_path_check(
> + TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT) < 0) {
> printf("failure occurred during checking valid alarm "
> "interrupt full path\n");
> goto out;
> @@ -513,6 +542,12 @@ test_interrupt(void)
> rte_intr_callback_unregister(&test_intr_handle,
> test_interrupt_callback_1, (void *)-1);
>=20
> + test_intr_handle =3D
> intr_handles[TEST_INTERRUPT_HANDLE_VALID_DEV_EVENT];
> + rte_intr_callback_unregister(&test_intr_handle,
> + test_interrupt_callback, (void *)-1);
> + rte_intr_callback_unregister(&test_intr_handle,
> + test_interrupt_callback_1, (void *)-1);
> +
> rte_delay_ms(2 * TEST_INTERRUPT_CHECK_INTERVAL);
> /* deinit */
> test_interrupt_deinit();
> --
> 2.7.4