From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C32BD99D5 for ; Mon, 31 Jul 2017 09:28:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 31 Jul 2017 00:28:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,440,1496127600"; d="scan'208";a="884562464" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jul 2017 00:28:30 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 31 Jul 2017 00:28:30 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 31 Jul 2017 00:28:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Mon, 31 Jul 2017 15:28:28 +0800 From: "Hu, Jiayu" To: Yuanhan Liu CC: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH] net/virtio: fix fail to configure rxq interrupt Thread-Index: AQHTAD1zHHvRkdfYLEqFMfSv2diFzqJsw0wAgACHVND//449gIAAvWxg Date: Mon, 31 Jul 2017 07:28:26 +0000 Message-ID: References: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> <20170731023016.GA9612@yliu-home> <20170731034727.GC9612@yliu-home> In-Reply-To: <20170731034727.GC9612@yliu-home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDM3ZjM1N2YtOWYzYi00OGVhLWE2MmEtMTllZWZkMWJiYTI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InU1c3MzWFBjSXc5d3h5YmlcL2lQQ0lrNVdqTjBObWtUS3c0TUVFWXd0WHI0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 07:28:32 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Monday, July 31, 2017 11:47 AM > To: Hu, Jiayu > Cc: Tan, Jianfeng ; dev@dpdk.org > Subject: Re: [PATCH] net/virtio: fix fail to configure rxq interrupt >=20 > On Mon, Jul 31, 2017 at 02:47:13AM +0000, Hu, Jiayu wrote: > > Hi Yuanhan, > > > > When we run l3fwd-power in VM with applying this patch in VM DPDK, > QEMU will crash. I think this patch can't solve the problem correctly but= I > haven't figured out the reason. I am so sorry about it. >=20 > It's okay. But you should reply earlier here, so that I would not apply i= t. >=20 > Regarding the crash, I believe Jianfeng had met a similar issue before. I= IRC, > it's about the order of event fd setups (or something like it). You might > want to contact him for more details. The root cause is that the interrupt should be set up before DRIVER_OK is sent to QEMU. Otherwise, QEMU will crash. The simplest way to enable RXQ interrupt after devices are initialized is t= o re-init them via virtio_init_devices(), rather than to call virtio_configur= e_intr() directly. This is also what Jianfeng does originally. BRs, Jiayu >=20 > And it's dropped. >=20 > --yliu >=20 > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > > > Sent: Monday, July 31, 2017 10:30 > > > To: Hu, Jiayu > > > Cc: dev@dpdk.org; Tan, Jianfeng ; Yao, Lei A > > > ; stable@dpdk.org > > > Subject: Re: [PATCH] net/virtio: fix fail to configure rxq interrupt > > > > > > On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote: > > > > When use rte_eth_dev_configure() to enable rx queue interrupt for > virtio > > > > devices, virtio_configure_intr() isn't called to set up the interru= pt > > > > environment, which causes rx queue interrupt setup failed. This pat= ch is > > > > to fix this issue. > > > > > > > > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Jiayu Hu > > > > > > Applied to dpdk-next-virtio. > > > > > > Thanks. > > > > > > --yliu