From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5C5A11B16C for ; Wed, 10 Jan 2018 02:55:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 17:55:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,337,1511856000"; d="scan'208";a="10028360" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 09 Jan 2018 17:55:20 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 17:55:19 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 09:55:17 +0800 From: "Hu, Jiayu" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "Chen, Junjie J" , "Tan, Jianfeng" , "stephen@networkplumber.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "Yao, Lei A" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup Thread-Index: AQHTheuus4MM4ZxlXEKyrkisolG+4qNrvIKAgACijHA= Date: Wed, 10 Jan 2018 01:55:16 +0000 Message-ID: References: <1513927544-97241-1-git-send-email-jiayu.hu@intel.com> <1515132769-52572-1-git-send-email-jiayu.hu@intel.com> <1515132769-52572-2-git-send-email-jiayu.hu@intel.com> <4091994.Mte9QLjkTW@xps> In-Reply-To: <4091994.Mte9QLjkTW@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRhMWUzOWEtNTg3Yi00OWRmLWEzZjktYjQyZTI0MDczMmNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhPaWE0WnlObVBhNmZYWUM2cVRMSzZSMmtGNmFER29BQU5raVhwNjhqcGM9In0= x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 01:55:21 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, January 10, 2018 8:09 AM > To: Hu, Jiayu > Cc: dev@dpdk.org; Richardson, Bruce ; Chen, > Junjie J ; Tan, Jianfeng ; > stephen@networkplumber.org; Yigit, Ferruh ; > Ananyev, Konstantin ; Yao, Lei A > > Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup >=20 > Hi, >=20 > 05/01/2018 07:12, Jiayu Hu: > > - Remove needless check and variants > > - For better understanding, update the programmer guide and rename > > internal functions and variants > > - For supporting tunneled gro, move common internal functions from > > gro_tcp4.c to gro_tcp4.h > > - Comply RFC 6864 to process the IPv4 ID field >=20 > I think you could split this patch in several ones. > Please remind that the git history can be used later to understand > why the changes were done. Thanks for your suggestion. I will split this patch into three patches: cod= e cleanup, comply RFC 6864 to process IPv4 ID field and extract common functions for s= upporting tunneled GRO. Regards, Jiayu >=20 > Thanks