From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2A8F4271 for ; Thu, 25 Jan 2018 04:07:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 19:07:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,409,1511856000"; d="scan'208";a="22138896" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 24 Jan 2018 19:07:01 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 19:07:00 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 19:07:00 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Thu, 25 Jan 2018 11:06:58 +0800 From: "Hu, Jiayu" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "shahafs@mellanox.com" , "Yao, Lei A" Thread-Topic: [PATCH] app/testpmd: fix failing to enable SW checksum calculation Thread-Index: AQHTlYGcDetS8BolpEyR8REfOJGdHKODX5CAgACIUQA= Date: Thu, 25 Jan 2018 03:06:57 +0000 Message-ID: References: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B715E6B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B715E6B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjBlNDdiZWUtMTJmMS00ZjRmLTgwMDEtYjcxMjBhNDMyZDJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imc0K3FMaTBOTCt1cFQ3ZWJNOXBVaXdRM1hpWERydVBXYUFIMHl2RmZVaWc9In0= x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 03:07:03 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, January 25, 2018 10:58 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: shahafs@mellanox.com; Yao, Lei A > Subject: RE: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation >=20 > Hi Jiayu, >=20 >=20 > > -----Original Message----- > > From: Hu, Jiayu > > Sent: Thursday, January 25, 2018 10:14 AM > > To: dev@dpdk.org > > Cc: shahafs@mellanox.com; Lu, Wenzhuo ; Yao, > Lei > > A ; Hu, Jiayu > > Subject: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation > > > > In current design, we can't enable SW checksum calculation for the devi= ces > > which don't have checksum offloading abilities via the command "csum se= t > > ip|tcp|udp|sctp|outer-ip sw ". > Confused, you mean it's an issue or the expected behavior? It's an issue. SW checksum calculation should support all devices. >=20 > > But SW checksum calculation shouldn't depend on HW offloading abilities= . > > This patch is to fix this issue. > > > > Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") > > Signed-off-by: Jiayu Hu > > --- > > app/test-pmd/cmdline.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 9f12c0f..a2db9b7 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -3706,40 +3706,40 @@ cmd_csum_parsed(void *parsed_result, > > hw =3D 1; > > > > if (!strcmp(res->proto, "ip")) { > > - if (dev_info.tx_offload_capa & > > - > > DEV_TX_OFFLOAD_IPV4_CKSUM) { > > + if (hw =3D=3D 0 || (dev_info.tx_offload_capa & > You mean SW can support the capability anyway, not need to check anything= , > right?