From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6EFE62BC7; Thu, 4 Oct 2018 04:31:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 19:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,338,1534834800"; d="scan'208";a="79720767" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 03 Oct 2018 19:31:20 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 3 Oct 2018 19:31:19 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 3 Oct 2018 19:31:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.140]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0319.002; Thu, 4 Oct 2018 10:31:11 +0800 From: "Hu, Jiayu" To: Jerin Jacob , Olivier Matz CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask Thread-Index: AQHUWj4LJZMZ8ZsIOkiFkcfPSHo9NaUOXh2g Date: Thu, 4 Oct 2018 02:31:11 +0000 Message-ID: References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> In-Reply-To: <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2Q0MTZlM2MtMmE4MS00YzgyLTkwNmQtN2E1NGM4MzA0ZDA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYjNxR1g2TUFxNCtybmdFZStVOHZraldyXC9uQ1JhU1Izc0s5YkhSUENiNGZSZ3JxMTlKK2ZxaVU5TE1cL0x5SWx6In0= x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 02:31:45 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 6:52 PM > To: Olivier Matz > Cc: dev@dpdk.org; Jerin Jacob ; > stable@dpdk.org; Hu, Jiayu > Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask >=20 > Fixes missing PKT_TX_UDP_SEG, > PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, > PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. >=20 > Also sort them in bit wise order to recognize missing items later. >=20 > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") > Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with R= x > ones") > Cc: stable@dpdk.org > Cc: jiayu.hu@intel.com >=20 > Signed-off-by: Jerin Jacob Acked-by: Jiayu Hu Thanks, Jiayu > --- > v2: > - Add all missing PKT_TX_ types > - Sort them in bit mask order(Ferruh Yigit) > --- > lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index a50b05c64..c8ebc3230 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -334,16 +334,21 @@ extern "C" { > * which can be set for packet. > */ > #define PKT_TX_OFFLOAD_MASK ( \ > + PKT_TX_OUTER_IPV6 | \ > + PKT_TX_OUTER_IPV4 | \ > + PKT_TX_OUTER_IP_CKSUM | \ > + PKT_TX_VLAN_PKT | \ > + PKT_TX_IPV6 | \ > + PKT_TX_IPV4 | \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > - PKT_TX_OUTER_IP_CKSUM | \ > - PKT_TX_TCP_SEG | \ > PKT_TX_IEEE1588_TMST | \ > + PKT_TX_TCP_SEG | \ > PKT_TX_QINQ_PKT | \ > - PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > PKT_TX_MACSEC | \ > - PKT_TX_SEC_OFFLOAD) > + PKT_TX_SEC_OFFLOAD | \ > + PKT_TX_UDP_SEG) >=20 > /** > * Mbuf having an external buffer attached. shinfo in mbuf must be fille= d. > -- > 2.19.0