From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <berestovskyy@gmail.com> Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A92DD2C8 for <dev@dpdk.org>; Thu, 24 May 2018 11:20:20 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id n10-v6so3157204wmc.1 for <dev@dpdk.org>; Thu, 24 May 2018 02:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3UB4oQBWUdeR2GXD+OoSEYU2y3eS60G1la4pJiJtNQg=; b=LLz0BXQhoxo2m8s/eTfwrUS0Fna+9HioefkPZRonRC1CnaudbHyZNPw7pYpaUHD3Jg J+yVvZBuwFU2Y8plJxHHyNcYIJwuhyADNe2K/wtRI7HLD8UbLD4Ip4+139Kcpp7C8v80 I5FyzX21690WaMr/CH+UNoy1fBhJPst+6sgIMrFNs4sMbo5qkscuhwh16efpTNKGFPgF 3jRptG0hhg98SHECbt79yzN3Lm4olTm72dpJi0ZSRZ8abwEe3hPin4wUXM1Yo3MZhQxV VGT1qoGms5jFAicAYagXTYMPq/5qvxATHi3HcTerqywIMbN+QCv6+JkTTWGVaMllyuc0 v0lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3UB4oQBWUdeR2GXD+OoSEYU2y3eS60G1la4pJiJtNQg=; b=rY05QfRqV9Q+PMv4Gjkp9JGTXorI7qCVhAj2vhuO2j3COsqdhhvxOqQbt4Q6lxi86W d3DtpXu2qbAFtnsKcIj3+OshtzPT6+hGWmPv4BIizY/cn/gw3VeTkrhnWbL17mhnVZyJ 0HtI62C4tSXGzcV1yulyTJ4Su5rk6GXQspkIZX+LrL1SSHaR+4l8GPDxMj0QCxq75FZ7 vUCnkGvUrMND5aZbQVNWUqJry+nqO4+TBbeXc/QSMKkJGTajJK9nOuxx+F6BoJSq5uuy /+FB8qPUf15Z2uQ3zQg2yfJSoUmOV5Zs2UqFusS8pg8QJdmDtEX6DWTaxqcjWWVEb42a HXfA== X-Gm-Message-State: ALKqPwdzwb83ot377mDQviXlkFOUA9HKmBvTEqow6WKnDl9LQvThcO6t PRk1bWpWIHNtyTNxu/3bJ/A= X-Google-Smtp-Source: AB8JxZpKcehMvEy7ON3Hoay5haGiB4kE1AuBVwjtRSMSQmVTDCs0Md8IJvIqgLX1oVpDuAFTCkfhbw== X-Received: by 2002:a50:ad8f:: with SMTP id a15-v6mr11059835edd.88.1527153620398; Thu, 24 May 2018 02:20:20 -0700 (PDT) Received: from beem.home ([2a02:120b:2c7e:cce0:f84e:954b:2edf:bfc0]) by smtp.gmail.com with ESMTPSA id v11-v6sm345258edm.26.2018.05.24.02.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 02:20:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) From: Andriy Berestovskyy <berestovskyy@gmail.com> In-Reply-To: <DB7PR05MB4426109FDE704ACB66A28D45C36B0@DB7PR05MB4426.eurprd05.prod.outlook.com> Date: Thu, 24 May 2018 11:20:18 +0200 Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "jerin.jacob@cavium.com" <jerin.jacob@cavium.com> Content-Transfer-Encoding: quoted-printable Message-Id: <EDBB9816-FD39-4657-BEEC-046C28A2FF70@gmail.com> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <abf49e30-6e40-641b-f668-dfd26c9be689@caviumnetworks.com> <1719643.qo6JmGv4pL@xps> <7564896.sbN2ypR4X7@xps> <DB7PR05MB4426109FDE704ACB66A28D45C36B0@DB7PR05MB4426.eurprd05.prod.outlook.com> To: Shahaf Shuler <shahafs@mellanox.com> X-Mailer: Apple Mail (2.3445.6.18) Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 24 May 2018 09:20:20 -0000 Hi Shahaf, > On 23 May 2018, at 07:21, Shahaf Shuler <shahafs@mellanox.com> wrote: > I think this patch addressing just small issue in a bigger problem. > The way I see it all application needs to specify is the max packet = size it expects to receive, nothing else(!).=20 [...] > IMO The "jumbo_frame" bit can be set by the underlying PMD directly to = the device registers given the max_rx_pkt_len configuration.=20 Sure, it can be deducted in PMD if max_rx_pkt_len is greater than the = normal frame size. The background behind this patch was to fix some examples on some = platforms by allowing them to just set the jumbo bit in config and let = the DPDK to deduct the optimal jumbo max_rx_pkt_len. There was also another patch which fixed those examples, so they first = query the max_rx_pkt_len and then pass it with the config: http://dpdk.org/commit/5e470a6654 That patch has been merged, so now we can fix/change the API in any way = we decide, there is no urgency anymore. Looks like the jumbo bit in config is redundant, but there might be = other opinions. Andriy