From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 11AA11B3DA for ; Wed, 28 Nov 2018 10:27:11 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51929DC8E8; Wed, 28 Nov 2018 09:27:10 +0000 (UTC) Received: from [10.36.116.109] (ovpn-116-109.ams2.redhat.com [10.36.116.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B4981054FD6; Wed, 28 Nov 2018 09:27:06 +0000 (UTC) From: "Eelco Chaudron" To: "David Marchand" Cc: cristian.dumitrescu@intel.com, dev@dpdk.org Date: Wed, 28 Nov 2018 10:27:04 +0100 Message-ID: In-Reply-To: References: <154333204294.44971.12989297399338053044.stgit@dbuild> <154333210155.44971.11196185167374567770.stgit@dbuild> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 28 Nov 2018 09:27:10 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 09:27:11 -0000 On 28 Nov 2018, at 9:38, David Marchand wrote: > Hello Eelco, > > On Tue, Nov 27, 2018 at 4:22 PM Eelco Chaudron > wrote: > >> Update the ABI to include the new RFC4115 meter functions >> --- >> lib/librte_meter/Makefile | 2 +- >> lib/librte_meter/meson.build | 2 +- >> lib/librte_meter/rte_meter_version.map | 9 +++++++++ >> 3 files changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_meter/Makefile b/lib/librte_meter/Makefile >> index 2dc071e8e..79ad79744 100644 >> --- a/lib/librte_meter/Makefile >> +++ b/lib/librte_meter/Makefile >> @@ -16,7 +16,7 @@ LDLIBS += -lrte_eal >> >> EXPORT_MAP := rte_meter_version.map >> >> -LIBABIVER := 2 >> +LIBABIVER := 3 >> >> # >> # all source are stored in SRCS-y >> > > As far as I understood the policy around the EXPERIMENTAL section, you > don't need to bump the library version. Thought I would add the new function as none experimental, i.e. next version, but checkpatch did not allow me to do this. Tried to find info on what the right process was, as these functions are just another meter implementation using similar existing APIs. If anyone has any background on this please point me to it. I changed the library version as an existing data structure changed (which in theory should not change the location of the data), but the ABI check popped warnings so I decided to increase the version. > > + you should squash this into the first patch. I’ll do this on the next version. Thanks, Eelco