From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <patrick.lu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 3D57DB0FC
 for <dev@dpdk.org>; Wed, 11 Jun 2014 23:58:45 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 11 Jun 2014 14:58:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="353820166"
Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34])
 by FMSMGA003.fm.intel.com with ESMTP; 11 Jun 2014 14:55:04 -0700
Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by
 FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id
 14.3.123.3; Wed, 11 Jun 2014 14:58:59 -0700
Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.134]) by
 FMSMSX154.amr.corp.intel.com ([169.254.6.165]) with mapi id 14.03.0123.003;
 Wed, 11 Jun 2014 14:58:59 -0700
From: "Lu, Patrick" <patrick.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] Add an API to query enabled core index
Thread-Index: AQHPhbe15uRbAOO7FkqQT9wOFzGoBZts6G2A//+Lr/A=
Date: Wed, 11 Jun 2014 21:58:58 +0000
Message-ID: <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53@FMSMSX101.amr.corp.intel.com>
References: <1402519509-26653-1-git-send-email-Patrick.Lu@intel.com>
 <9007853.cgh6aaULN3@xps13>
In-Reply-To: <9007853.cgh6aaULN3@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.1.200.107]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jun 2014 21:58:45 -0000

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20
Sent: Wednesday, June 11, 2014 2:51 PM
To: Lu, Patrick
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index

Hi,

2014-06-11 13:45, Patrick Lu:
> EAL -c option allows the user to enable any lcore in the system.
> Oftentimes, the user app wants to know 1st enabled core, 2nd enabled=20
> core, etc, rather than phyical core ID (rte_lcore_id().)
>=20
> The new API rte_lcore_id2() will return an index from enabled lcores=20
> starting from zero.

I think core_id2 is not a representative name.
What do you think of renaming core_id as lcore_hwid and core_id2 as lcore_i=
ndex?

--
Thomas

I think this is a good idea. Except core_id is used in 13 other places. Sho=
uld I resubmit the patch with core_id renamed it lcore_hwid?

Patrick