From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C411FA04F5; Thu, 12 Dec 2019 13:04:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27538374C; Thu, 12 Dec 2019 13:04:58 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 91AF22BD3 for ; Thu, 12 Dec 2019 13:04:56 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id p17so2209872wmi.3 for ; Thu, 12 Dec 2019 04:04:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fMcvVigg3ZZhWe98CmpsMJVQZda+mUccuht8eO76k+c=; b=Mab8NePWlB5xjnTPKLlzwYUzn1ps3FduksQ0SrBkHDDezjfFmnct4eUeY5/GonF1BA /GFpzDPnZ+JqiRsUYiBYcp2R3pMppbceMV8jRR3AJj3FXGxxsgDUUYAbTISiK4MyZI7E rJOHGJEDSQpb5UJAPr/dyl502y0mTtacr4T8xjzrkWj5gBGyiTLD8ROKZobbaNpstaPG rwmawEqMGgaohQGRCj/duVOw8o8k7qirm19F+yl0INVh7H4UlDABh6tHyVhc6oWIXHqR jMc0o3E4tZMkHWH6Dwp9IFSDVRjCRR4n6J/JuFOS6bltnfhTZ1kOPDnP6Eqjj//2IBjo ioAw== X-Gm-Message-State: APjAAAXY7WNn7warOR6BCP0SKWnu9z72C3jewbBuLfhxf0NqyvkPL/lG 7w44fZg81hY+WHkd4pd+Wt0= X-Google-Smtp-Source: APXvYqwi24WJeyZIse1K9ttighyX1DuFf0FTbQtLQq91RMKtvby9e2Zod3+BsQJTjAj3yptlRWoyHQ== X-Received: by 2002:a1c:9e58:: with SMTP id h85mr6294239wme.77.1576152296291; Thu, 12 Dec 2019 04:04:56 -0800 (PST) Received: from [192.168.1.118] (host31-202-dynamic.33-79-r.retail.telecomitalia.it. [79.33.202.31]) by smtp.gmail.com with ESMTPSA id k4sm6138168wmk.26.2019.12.12.04.04.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2019 04:04:55 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) From: Alfredo Cardigliano In-Reply-To: Date: Thu, 12 Dec 2019 13:04:52 +0100 Cc: John McNamara , Marko Kovacevic , Anatoly Burakov , dev@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20191209214656.27347-1-cardigliano@ntop.org> <20191209214656.27347-5-cardigliano@ntop.org> To: Ferruh Yigit X-Mailer: Apple Mail (2.3601.0.10) Subject: Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On 10 Dec 2019, at 19:50, Ferruh Yigit wrote: >=20 > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Register the Pensando ionic PMD (net_ionic) and define initial probe >> and remove callbacks with adapter initialization. >>=20 >> Signed-off-by: Alfredo Cardigliano >> Reviewed-by: Shannon Nelson >=20 > <...> >=20 >> +/* >> + * There is no room in struct rte_pci_driver to keep a reference >> + * to the adapter, using a static list for the time being. >> + */ >> +static LIST_HEAD(ionic_pci_adapters_list, ionic_adapter) = ionic_pci_adapters =3D >> + LIST_HEAD_INITIALIZER(ionic_pci_adapters); >> +static rte_spinlock_t ionic_pci_adapters_lock =3D = RTE_SPINLOCK_INITIALIZER; >=20 > As described in previous version of the patchset, it is possible to = remove the > PMD maintained list of adapters, is there any benefit to keep it? I will try to implement the approach you recommended. If that looks = messy,=20 is it a problem to keep this static list? Thank you Alfredo=