From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 499607E72
 for <dev@dpdk.org>; Wed, 15 Oct 2014 08:48:35 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 14 Oct 2014 23:52:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,721,1406617200"; d="scan'208";a="589223036"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by orsmga001.jf.intel.com with ESMTP; 14 Oct 2014 23:54:52 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 14 Oct 2014 23:54:52 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 14 Oct 2014 23:54:52 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.230]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.203]) with mapi id 14.03.0195.001;
 Wed, 15 Oct 2014 14:54:50 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
Thread-Index: AQHP6CZMhgwHBKWhOUCv8VtLaEWvQJwwuUZw
Date: Wed, 15 Oct 2014 06:54:50 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C5EF@SHSMSX104.ccr.corp.intel.com>
References: <1413342878-18584-1-git-send-email-jijiang.liu@intel.com>
In-Reply-To: <1413342878-18584-1-git-send-email-jijiang.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2014 06:48:35 -0000

Acked-by: Helin Zhang <helin.zhang@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Wednesday, October 15, 2014 11:15 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
>=20
> This patch adds incoming packet error statistics in the i40e_ethdev.c fil=
e.
>=20
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 46c43a7..dbf231f 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1274,6 +1274,9 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>=20
>  	pf->offset_loaded =3D true;
>=20
> +	if (pf->main_vsi)
> +		i40e_update_vsi_stats(pf->main_vsi);
> +
>  	stats->ipackets =3D ns->eth.rx_unicast + ns->eth.rx_multicast +
>  						ns->eth.rx_broadcast;
>  	stats->opackets =3D ns->eth.tx_unicast + ns->eth.tx_multicast + @@
> -1283,8 +1286,12 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>  	stats->oerrors  =3D ns->eth.tx_errors;
>  	stats->imcasts  =3D ns->eth.rx_multicast;
>=20
> -	if (pf->main_vsi)
> -		i40e_update_vsi_stats(pf->main_vsi);
> +	/* Rx Errors */
> +	stats->ibadcrc  =3D ns->crc_errors;
> +	stats->ibadlen  =3D ns->rx_length_errors + ns->rx_undersize +
> +			ns->rx_oversize + ns->rx_fragments + ns->rx_jabber;
> +	stats->imissed  =3D ns->eth.rx_discards;
> +	stats->ierrors  =3D stats->ibadcrc + stats->ibadlen + stats->imissed;
>=20
>  	PMD_DRV_LOG(DEBUG, "***************** PF stats start
> *******************");
>  	PMD_DRV_LOG(DEBUG, "rx_bytes:            %lu",
> ns->eth.rx_bytes);
> --
> 1.7.7.6