From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5190D7E75 for ; Thu, 23 Oct 2014 04:15:55 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2014 19:24:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,773,1406617200"; d="scan'208";a="609717902" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga001.fm.intel.com with ESMTP; 22 Oct 2014 19:24:15 -0700 Received: from pgsmsx104.gar.corp.intel.com (10.221.44.91) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 23 Oct 2014 10:23:33 +0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 23 Oct 2014 10:23:33 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.44]) with mapi id 14.03.0195.001; Thu, 23 Oct 2014 10:23:32 +0800 From: "Zhang, Helin" To: Thomas Monjalon , "Liu, Jijiang" Thread-Topic: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Thread-Index: AQHP7dSuP9C37dUi9keoKNtdopapq5w88WFA Date: Thu, 23 Oct 2014 02:23:30 +0000 Message-ID: References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <2450996.3KDeDxoTz7@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> <1710340.mrZid3JfsP@xps13> In-Reply-To: <1710340.mrZid3JfsP@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2014 02:15:56 -0000 Hi > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 22, 2014 4:46 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure > changes >=20 > 2014-10-21 14:14, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-21 16:46, Jijiang Liu: > > > > - uint16_t reserved2; /**< Unused field. Required for padding > */ > > > > + > > > > + /** > > > > + * Packet type, which is used to indicate ordinary L2 packet form= at > and > > > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC i= n GRE > > > > + * and MAC in UDP. > > > > + */ > > > > + uint16_t packet_type; > > > > > > Why not name it "l2_type"? 'packet_type' is for storing the hardware identified packet type upon diffe= rent layers of protocols (l2, l3, l4, ...). It is quite useful for user application or middle layer software stacks, it= can know what the packet type is without checking the packet too much by software. Actually ixgbe already has packet types (less than 10), which is transcoded= into 'ol_flags'. For i40e, the packet type can represent about 256 types of packet, 'ol_flag= s' does not have enough bits for it anymore. So put the i40e packet types into mbuf wou= ld be better. Also this field can be used for NON-Intel NICs, I think there must be the s= imilar concepts of other NICs. And 16 bits 'packet_type' has severl reserved bits for futur= e and NON-Intel NICs. > > > > In datasheet, this term is called packet type(s). >=20 > That's exactly the point I want you really understand! > This is a field in generic mbuf structure, so your datasheet has no value= here. >=20 > > Personally , I think packet type is more clear what meaning of this fi= eld is . > ^_^ >=20 > You cannot add an API field without knowing what will be its generic mean= ing. > Please think about it and describe its scope. >=20 > Thanks > -- > Thomas Regards, Helin