From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 09C9F5917
 for <dev@dpdk.org>; Tue, 28 Oct 2014 01:29:57 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 27 Oct 2014 17:32:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="406984714"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2014 17:30:41 -0700
Received: from kmsmsx153.gar.corp.intel.com (172.21.73.88) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 28 Oct 2014 08:37:50 +0800
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 28 Oct 2014 08:37:49 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.156]) with mapi id 14.03.0195.001;
 Tue, 28 Oct 2014 08:37:43 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of
 redirection table
Thread-Index: AQHP8fGzAH2dotGp9Eu7EEx+dND6JJxEqb/Q
Date: Tue, 28 Oct 2014 00:37:42 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AB9E2@SHSMSX104.ccr.corp.intel.com>
References: <1411634427-746-1-git-send-email-helin.zhang@intel.com>
 <1413978810-24610-1-git-send-email-helin.zhang@intel.com>
 <1413978810-24610-8-git-send-email-helin.zhang@intel.com>
 <2549150.oVMv5n2oYl@xps13>
In-Reply-To: <2549150.oVMv5n2oYl@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of
 redirection table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 00:29:59 -0000

Hi Thomas

See my answers inlined.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 27, 2014 10:24 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes =
of
> redirection table
>=20
> 2014-10-22 19:53, Helin Zhang:
> > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t))
>=20
> How can it be different of 64?
> Using 64 would be simpler to understand than RTE_BIT_WIDTH_64.
>=20
> > +	uint8_t reta[RTE_BIT_WIDTH_64]; /**< 64 redirection table entries. */
We always try to use macro in code to replace numeric, this can get the num=
eric more understandable.

>=20
> Even your comment is saying that it's 64.
>=20
> --
> Thomas

Regards,
Helin