From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5C8067F98 for ; Wed, 29 Oct 2014 09:16:59 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 29 Oct 2014 01:25:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,808,1406617200"; d="scan'208";a="622627828" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 29 Oct 2014 01:25:47 -0700 Received: from pgsmsx105.gar.corp.intel.com (10.221.44.96) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 16:24:08 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by pgsmsx105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 16:24:08 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Wed, 29 Oct 2014 16:24:07 +0800 From: "Zhang, Helin" To: 'Thomas Monjalon' Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP7Zkufu3qEL3+S0+ks7KzOBBUo5xErn9AgAAe6wCAAKLHEIABVv4w Date: Wed, 29 Oct 2014 08:24:07 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <4337777.fZJZ2Jprv9@xps13> <3230077.QOtjOU5lvA@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "'dev@dpdk.org'" Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 08:16:59 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Tuesday, October 28, 2014 8:01 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size= s of > redirection table >=20 > Hi Thomas >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, October 28, 2014 6:10 PM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple > > sizes of redirection table > > > > 2014-10-28 00:33, Zhang, Helin: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2014-09-25 16:40, Helin Zhang: > > > > > /* Definitions used for redirection table entry size */ > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > +#define ETH_RSS_RETA_SIZE_64 64 #define ETH_RSS_RETA_SIZE_128 > > > > > +128 #define ETH_RSS_RETA_SIZE_512 > > > > > +512 > > > > > + > > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > > > Are these constants really needed? > > > > > > These constants were defined for the third input parameter of > > > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End > > > users need to give the correct reta size listed as above, as other > > > values is not valid. So it would be better to list the valid reta > > > sizes in macros > > here. > > > > OK, so you should explain that only these values are allowed. > > In general, it's something we explain in the comment of the function > It would be better to add comments for the functions. Now do not think explain what value is allowed for the functions in ethdev = layer, as it might be hardware specific. I think the best way is to comment out end users can get the reta size by 'dev_infos_get' on each port, rather than telling the values directly. >=20 > > > > By the way, why only these values are allowed? > It depends on hardware, 1G/10G hardware supports 128 reta size only, 40G > hardware supports 512 or 128 depends on hardware configuration, 40G VF > hardware supports 64. If more is introduced in the future, more values ca= n be > added later. It will return with errors if reta size is not supported for= specific > hardware. >=20 > > > > -- > > Thomas >=20 > Regards, > Helin Regards, Helin