From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 983597F30
 for <dev@dpdk.org>; Tue, 25 Nov 2014 01:18:31 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 24 Nov 2014 16:29:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,451,1413270000"; d="scan'208";a="637484686"
Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96])
 by fmsmga002.fm.intel.com with ESMTP; 24 Nov 2014 16:28:42 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 pgsmsx105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 25 Nov 2014 08:28:37 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0195.001;
 Tue, 25 Nov 2014 08:28:30 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v6 8/8] i40evf: support of updating/querying
 redirection table
Thread-Index: AQHQCDTwBXC3hOjTbE+V2CVxc4RJb5xwfKkQ
Date: Tue, 25 Nov 2014 00:28:29 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7CA7DF@SHSMSX104.ccr.corp.intel.com>
References: <1415283932-20724-1-git-send-email-helin.zhang@intel.com>
 <1416067424-31699-1-git-send-email-helin.zhang@intel.com>
 <1416067424-31699-9-git-send-email-helin.zhang@intel.com>
 <12900952.nb83Kz7Ga1@xps13>
In-Reply-To: <12900952.nb83Kz7Ga1@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 8/8] i40evf: support of updating/querying
 redirection table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 00:18:32 -0000

Hi Thomas

Thank you for the fixes! I am using the checkpatch.pl of kernel 3.6.10. Yes=
, It seems that I need to update it to a newer version.

Regards,
Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, November 25, 2014 6:20 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 8/8] i40evf: support of updating/queryi=
ng
> redirection table
>=20
> Helin,
>=20
> I fixed these errors before applying:
>=20
> WARNING:MISSING_SPACE: break quoted strings at a space character
> #134: FILE: lib/librte_pmd_i40e/i40e_ethdev_vf.c:1705:
> +                       "(%d) doesn't match the number of hardware can"
> +                       "support (%d)\n", reta_size,
> ETH_RSS_RETA_SIZE_64);
>=20
> WARNING:MISSING_SPACE: break quoted strings at a space character
> #177: FILE: lib/librte_pmd_i40e/i40e_ethdev_vf.c:1748:
> +                       "(%d) doesn't match the number of hardware can"
> +                       "support (%d)\n", reta_size,
> ETH_RSS_RETA_SIZE_64);
>=20
> You should update your checkpatch, it checks more and more things.
> It's really useful ;)
>=20
> --
> Thomas