From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EED269A9B
 for <dev@dpdk.org>; Tue,  3 Feb 2015 06:24:25 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 02 Feb 2015 21:20:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,510,1418112000"; d="scan'208";a="680035127"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by orsmga002.jf.intel.com with ESMTP; 02 Feb 2015 21:24:14 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 3 Feb 2015 13:24:13 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0195.001;
 Tue, 3 Feb 2015 13:24:13 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 4/7] ethdev: fix of calculating the size of
 flow type mask array
Thread-Index: AQHQPv1heWngI0syhEaqZ8MRQWYUuZzeZRbg
Date: Tue, 3 Feb 2015 05:24:11 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A803E18@SHSMSX104.ccr.corp.intel.com>
References: <1421650577-25969-1-git-send-email-helin.zhang@intel.com>
 <1421650577-25969-5-git-send-email-helin.zhang@intel.com>
 <2108624.Ik2ARBIxyb@xps13>
In-Reply-To: <2108624.Ik2ARBIxyb@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/7] ethdev: fix of calculating the size of
 flow type mask array
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2015 05:24:26 -0000

Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, February 2, 2015 11:31 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/7] ethdev: fix of calculating the size o=
f flow
> type mask array
>=20
> Hi Helin,
>=20
> 2015-01-19 14:56, Helin Zhang:
> > +#define UINT32_BIT (CHAR_BIT * sizeof(uint32_t))
>=20
> I don't understand how UINT32_BIT is better than a simple sizeof(uint32_t=
)?
UINT32_BIT is 32, while sizeof(uint32_t) is 4. They are different.

Regards,
Helin

>=20
> --
> Thomas