From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 302805A30 for ; Fri, 20 Feb 2015 15:27:04 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 20 Feb 2015 06:26:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,614,1418112000"; d="scan'208";a="654834091" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga001.jf.intel.com with ESMTP; 20 Feb 2015 06:26:46 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 20 Feb 2015 22:26:44 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 22:26:43 +0800 From: "Zhang, Helin" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types Thread-Index: AQHQSpB/9qmyRYNB9Eu0DUlZVZzlvJz5nKJg Date: Fri, 20 Feb 2015 14:26:43 +0000 Message-ID: References: <1422501365-12643-1-git-send-email-helin.zhang@intel.com> <1424156374-21768-1-git-send-email-helin.zhang@intel.com> <1424156374-21768-4-git-send-email-helin.zhang@intel.com> <54E30374.4010809@6wind.com> In-Reply-To: <54E30374.4010809@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 14:27:04 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, February 17, 2015 5:02 PM > To: Zhang, Helin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified= packet > types >=20 > Hi Helin, >=20 > On 02/17/2015 07:59 AM, Helin Zhang wrote: > > As there are only 6 bit flags in ol_flags for indicating packet types, > > which is not enough to describe all the possible packet types hardware > > can recognize. For example, i40e hardware can recognize more than 150 > > packet types. Unified packet type is composed of L2 type, L3 type, L4 > > type, tunnel type, inner L2 type, inner L3 type and inner L4 type > > fields, and can be stored in 'struct rte_mbuf' of 32 bits field > > 'packet_type'. > > > > Signed-off-by: Helin Zhang >=20 > A formal definition of each flag is still missing. I explained several ti= mes why it's > needed. We must be able to answer to these > questions: >=20 > - If I'm developing a PMD, what fields should I check in the packet > to set a specific flag? > - If I'm developing an application, if a specific flag is set, what > checks can I skip? >=20 > Example with RTE_PTYPE_L3_IPV4: >=20 > - IP version field is 4 > - no IP options (header size is 20) > - layer 2 identified the packet as IP (ex: ethertype=3D0x800) >=20 > I think we need such a definition for all packet types. You meant we need a detailed description of each packet type, right? If yes, I can add those information soon. Thanks for the helps! Regards, Helin >=20 > Regards, > Olivier