From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ABB5B11C5 for ; Wed, 4 Mar 2015 09:34:25 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 04 Mar 2015 00:29:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,686,1418112000"; d="scan'208";a="674903596" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by fmsmga001.fm.intel.com with ESMTP; 04 Mar 2015 00:34:22 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 4 Mar 2015 16:34:21 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by shsmsx102.ccr.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0195.001; Wed, 4 Mar 2015 16:34:20 +0800 From: "Zhang, Helin" To: "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in rte_mbuf Thread-Index: AQHQUo8NCbApITdTRkSFMj6AcoYVZJ0JEt8QgALzGDA= Date: Wed, 4 Mar 2015 08:34:19 +0000 Message-ID: References: <1424156374-21768-1-git-send-email-helin.zhang@intel.com> <1425042696-23162-1-git-send-email-helin.zhang@intel.com> <1425042696-23162-2-git-send-email-helin.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in rte_mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 08:34:26 -0000 > -----Original Message----- > From: Chilikin, Andrey > Sent: Monday, March 2, 2015 7:48 PM > To: Zhang, Helin; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_typ= e in > rte_mbuf >=20 > Hi Helin, >=20 > I see that you have removed "uint16_t reserved" member from rte_mbuf: >=20 > > + uint16_t data_len; /**< Amount of data in segment buffer. */ > > uint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order= ) > */ > > - uint16_t reserved; > > union { > > uint32_t rss; /**< RSS hash result if RSS enabled */ >=20 > This reserved field was kept next to vlan_tci as a placeholder for the s= econd > VLAN label for QinQ support so if need be vlan_tci + reserved could be ca= sted to > 32 bit QinQ value or one 32bit VNTAG label. Without keeping two label adj= usted > to each other casting to 32 bit will not be possible and will affect QinQ > performance. Yes, but packet type is quite important which needs to be extended from 16 = bits to 32 bits. For FVL, the vlan tags are in different fields. We can think of putting the= m together in mbuf, Possibly move current vlan tag down, and add one more 16 bits. Let's see wh= at is the best then. Thanks for the notes! Regards, Helin >=20 > Regards, > Andrey >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang > > Sent: Friday, February 27, 2015 1:11 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type > > in rte_mbuf > > > > In order to unify the packet type, the field of 'packet_type' in > > 'struct rte_mbuf' needs to be extended from 16 to 32 bits. > > Accordingly, some fields in 'struct rte_mbuf' are re-organized to > > support this change for Vector PMD. As 'struct rte_kni_mbuf' for KNI > > should be right mapped to 'struct rte_mbuf', it should be modified > > accordingly. In addition, Vector PMD of ixgbe is disabled by default, a= s 'struct > rte_mbuf' changed. > > > > Signed-off-by: Helin Zhang > > Signed-off-by: Cunming Liang > > --- > > config/common_linuxapp | 2 +- > > .../linuxapp/eal/include/exec-env/rte_kni_common.h | 4 ++-- > > lib/librte_mbuf/rte_mbuf.h | 23 > +++++++++++++++------- > > 3 files changed, 19 insertions(+), 10 deletions(-) > > > > v2 changes: > > * Enlarged the packet_type field from 16 bits to 32 bits. > > * Redefined the packet type sub-fields. > > * Updated the 'struct rte_kni_mbuf' for KNI according to the mbuf chang= es. > > > > v3 changes: > > * Put the mbuf layout changes into a single patch. > > * Disabled vector ixgbe PMD by default, as mbuf layout changed. > > > > diff --git a/config/common_linuxapp b/config/common_linuxapp index > > 97f1c9e..97d7bae 100644 > > --- a/config/common_linuxapp > > +++ b/config/common_linuxapp > > @@ -166,7 +166,7 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=3Dn > > CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=3Dn > > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=3Dn > > CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=3Dy > > -CONFIG_RTE_IXGBE_INC_VECTOR=3Dy > > +CONFIG_RTE_IXGBE_INC_VECTOR=3Dn > > CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=3Dy > > > > # > > diff --git > > a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > > b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > > index 1e55c2d..bd1cc09 100644 > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > > @@ -117,9 +117,9 @@ struct rte_kni_mbuf { > > uint16_t data_off; /**< Start address of data in segment buffer.= */ > > char pad1[4]; > > uint64_t ol_flags; /**< Offload features. */ > > - char pad2[2]; > > - uint16_t data_len; /**< Amount of data in segment buffer. */ > > + char pad2[4]; > > uint32_t pkt_len; /**< Total pkt len: sum of all segment data_l= en. > > */ > > + uint16_t data_len; /**< Amount of data in segment buffer. */ > > > > /* fields on second cache line */ > > char pad3[8] __attribute__((__aligned__(RTE_CACHE_LINE_SIZE))); > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 17ba791..f5b7a8b 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -258,17 +258,26 @@ struct rte_mbuf { > > /* remaining bytes are set on RX when pulling packet from descriptor > > */ > > MARKER rx_descriptor_fields1; > > > > - /** > > - * The packet type, which is used to indicate ordinary packet and als= o > > - * tunneled packet format, i.e. each number is represented a type of > > - * packet. > > + /* > > + * The packet type, which is the combination of outer/inner L2, L3, L= 4 > > + * and tunnel types. > > */ > > - uint16_t packet_type; > > + union { > > + uint32_t packet_type; /**< L2/L3/L4 and tunnel information. > > */ > > + struct { > > + uint32_t l2_type:4; /**< (Outer) L2 type. */ > > + uint32_t l3_type:4; /**< (Outer) L3 type. */ > > + uint32_t l4_type:4; /**< (Outer) L4 type. */ > > + uint32_t tun_type:4; /**< Tunnel type. */ > > + uint32_t inner_l2_type:4; /**< Inner L2 type. */ > > + uint32_t inner_l3_type:4; /**< Inner L3 type. */ > > + uint32_t inner_l4_type:4; /**< Inner L4 type. */ > > + }; > > + }; > > > > - uint16_t data_len; /**< Amount of data in segment buffer. */ > > uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ > > + uint16_t data_len; /**< Amount of data in segment buffer. */ > > uint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order= ) > */ > > - uint16_t reserved; > > union { > > uint32_t rss; /**< RSS hash result if RSS enabled */ > > struct { > > -- > > 1.9.3