From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 74D299A92 for ; Tue, 26 May 2015 17:00:19 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 26 May 2015 08:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,498,1427785200"; d="scan'208";a="735451137" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 26 May 2015 08:00:17 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 26 May 2015 23:00:16 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by SHSMSX101.ccr.corp.intel.com ([10.239.4.153]) with mapi id 14.03.0224.002; Tue, 26 May 2015 23:00:15 +0800 From: "Zhang, Helin" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan Thread-Index: AQHQl8QI4FAnleAkdEi17M46qfgc8p2OWOYA Date: Tue, 26 May 2015 15:00:14 +0000 Message-ID: References: <1430793143-3610-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-3-git-send-email-helin.zhang@intel.com> <20150526075515.1bc42ae1@urahara> In-Reply-To: <20150526075515.1bc42ae1@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 15:00:20 -0000 Hi Stephen > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, May 26, 2015 10:55 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for > double vlan >=20 > On Tue, 26 May 2015 16:36:37 +0800 > Helin Zhang wrote: >=20 > > Use the reserved 16 bits in rte_mbuf structure for the outer vlan, > > also add QinQ offloading flags for both RX and TX sides. > > > > Signed-off-by: Helin Zhang >=20 > Yet another change that is much needed, but breaks ABI compatibility. Even just use the reserved 16 bits? It seems yes. Would it be acceptable to use the original name of 'reserved' for the outer= vlan? And then announce the name change, and rename it one release after? Regards, Helin