From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 10BBCC316 for ; Tue, 2 Jun 2015 05:44:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 01 Jun 2015 20:44:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,537,1427785200"; d="scan'208";a="719084904" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2015 20:44:53 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 2 Jun 2015 11:44:39 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.180]) with mapi id 14.03.0224.002; Tue, 2 Jun 2015 11:44:37 +0800 From: "Zhang, Helin" To: Simon Kagstrom , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups Thread-Index: AQHQiMhQhanhrsVTq0eM1gRBqOC9d52YuyLw Date: Tue, 2 Jun 2015 03:44:37 +0000 Message-ID: References: <20150507151754.1620c4cb@miho> In-Reply-To: <20150507151754.1620c4cb@miho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 03:44:55 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom > Sent: Thursday, May 7, 2015 9:18 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle > multicast groups >=20 > This is needed to add / remove interfaces in multicast groups via the ip = tool. Could you help to explain with more details of why it is needed? Thanks, Helin >=20 > The callback does nothing - the same as the kernel tun.c. >=20 > Signed-off-by: Simon Kagstrom > --- > Marked RFC since I'm by no means an expert on this. We noticed this when > playing with KNI and IGMP handling. >=20 > lib/librte_eal/linuxapp/kni/kni_net.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c > b/lib/librte_eal/linuxapp/kni/kni_net.c index dd95db5..cf93c4b 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_net.c > +++ b/lib/librte_eal/linuxapp/kni/kni_net.c > @@ -495,6 +495,11 @@ kni_net_ioctl(struct net_device *dev, struct ifreq *= rq, int > cmd) return 0; } >=20 > +static void > +kni_net_set_rx_mode(struct net_device *dev) { } > + > static int > kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -645,6 > +650,7 @@ static const struct net_device_ops kni_net_netdev_ops =3D > { .ndo_start_xmit =3D kni_net_tx, > .ndo_change_mtu =3D kni_net_change_mtu, > .ndo_do_ioctl =3D kni_net_ioctl, > + .ndo_set_rx_mode =3D kni_net_set_rx_mode, > .ndo_get_stats =3D kni_net_stats, > .ndo_tx_timeout =3D kni_net_tx_timeout, > .ndo_set_mac_address =3D kni_net_set_mac, > -- > 1.9.1