From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 82A0F5A0A for ; Fri, 12 Jun 2015 08:07:01 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 11 Jun 2015 23:07:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,600,1427785200"; d="scan'208";a="741953756" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga002.fm.intel.com with ESMTP; 11 Jun 2015 23:06:59 -0700 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 12 Jun 2015 14:06:41 +0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 12 Jun 2015 14:06:40 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.129]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002; Fri, 12 Jun 2015 14:06:39 +0800 From: "Zhang, Helin" To: "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size Thread-Index: AQHQnpjigkYRaMPWQUioxfC5T0983p2cJc5AgAxG0JA= Date: Fri, 12 Jun 2015 06:06:38 +0000 Message-ID: References: <1433379638-32715-1-git-send-email-helin.zhang@intel.com> <1433403216-7114-1-git-send-email-helin.zhang@intel.com> <1433403216-7114-2-git-send-email-helin.zhang@intel.com> <2601191342CEEE43887BDE71AB97725821434EFF@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725821434EFF@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 06:07:02 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, June 4, 2015 6:38 PM > To: Zhang, Helin; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying = hash > key size >=20 > Hi Helin, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang > > Sent: Thursday, June 04, 2015 8:34 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying > > hash key size > > > > To support querying hash key size per port, an new field of > > 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing > > hash key size in bytes. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_ether/rte_ethdev.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > v2 changes: > > * Disabled the code changes by default, to avoid breaking ABI compatibi= lity. > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > b/lib/librte_ether/rte_ethdev.h index 16dbe00..bdebc87 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -916,6 +916,9 @@ struct rte_eth_dev_info { > > uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */ > > uint32_t rx_offload_capa; /**< Device RX offload capabilities. */ > > uint32_t tx_offload_capa; /**< Device TX offload capabilities. */ > > +#ifdef RTE_QUERY_HASH_KEY_SIZE > > + uint8_t hash_key_size; /**< Hash key size in bytes */ #endif > > uint16_t reta_size; > > /**< Device redirection table size, the total number of entries. */ > > /** Bit mask of RSS offloads, the bit offset also means flow type */ >=20 > Why do you need to introduce an #ifdef RTE_QUERY_HASH_KEY_SIZE around > your code? > Why not to have it always on? > Is it because of not breaking ABI for 2.1? > But here, I suppose there would be no breakage anyway: >=20 > struct rte_eth_dev_info { > ... > uint32_t tx_offload_capa; /**< Device TX offload capabilities. */ > uint16_t reta_size; > /**< Device redirection table size, the total number of entries. = */ > /** Bit mask of RSS offloads, the bit offset also means flow type= */ > uint64_t flow_type_rss_offloads; > struct rte_eth_rxconf default_rxconf; >=20 >=20 > so between 'reta_size' and 'flow_type_rss_offloads', there is a 2 bytes g= ap. > Wonder, why not put it there? Oh, yes, you are totally right. There should be a 2 bytes padding there. I will rework it with that. Thanks! Helin >=20 > Konstantin >=20 > > -- > > 1.9.3