From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 801D65A3E for ; Thu, 16 Jul 2015 21:20:20 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 16 Jul 2015 12:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,489,1432623600"; d="scan'208";a="607616581" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga003.jf.intel.com with ESMTP; 16 Jul 2015 12:20:19 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 17 Jul 2015 03:20:17 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.129]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.157]) with mapi id 14.03.0224.002; Fri, 17 Jul 2015 03:20:16 +0800 From: "Zhang, Helin" To: "Tao, Zhe" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the DD bits are multiplex with descriptor type field. so cannot use "not zero" as the rule for the completion of Tx descriptor Thread-Index: AQHQtbNs4SGwy17GuEy4Gl+nt4fRWp3ejV4g Date: Thu, 16 Jul 2015 19:20:16 +0000 Message-ID: References: <1435943507-2679-1-git-send-email-zhe.tao@intel.com> In-Reply-To: <1435943507-2679-1-git-send-email-zhe.tao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the DD bits are multiplex with descriptor type field. so cannot use "not zero" as the rule for the completion of Tx descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 19:20:21 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhe Tao > Sent: Friday, July 3, 2015 10:12 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the= DD bits > are multiplex with descriptor type field. so cannot use "not zero" as the= rule for > the completion of Tx descriptor >=20 > If the descriptor in the position desc_to_clean_to is the context descrip= tor its > type will be 0x1, so using the not expression, the device driver will con= sider the > descriptor has been complete for transmission even its DTYPE field is sti= ll 0x1 > which means NIC has't finished the operation on this descriptor. >=20 > Signed-off-by: Zhe Tao Acked-by: Helin Zhang