From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0E1EC5A76 for ; Tue, 27 Oct 2015 08:54:33 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 27 Oct 2015 00:54:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,203,1444719600"; d="scan'208";a="835901158" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 27 Oct 2015 00:54:33 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Oct 2015 00:54:32 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Oct 2015 00:54:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.194]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Tue, 27 Oct 2015 15:54:30 +0800 From: "Zhang, Helin" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH 4/4] doc: extend commands in testpmd and remove related ABI deprecation Thread-Index: AQHQ9Ok9G/QI+FCCXEKkapghG75aWp5/L0gQ Date: Tue, 27 Oct 2015 07:54:29 +0000 Message-ID: References: <1442893533-32546-1-git-send-email-jingjing.wu@intel.com> <1442893533-32546-5-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1442893533-32546-5-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] doc: extend commands in testpmd and remove related ABI deprecation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 07:54:34 -0000 I am not sure if doc udpated here is what we expected or not. Any guidance on this from ABI experts? Regards, Helin > -----Original Message----- > From: Wu, Jingjing > Sent: Tuesday, September 22, 2015 11:46 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Lu, Wenzhuo; Xu, HuilongX > Subject: [PATCH 4/4] doc: extend commands in testpmd and remove related A= BI > deprecation >=20 > Modify the doc about flow director commands to support filtering in VFs. > Remove related ABI deprecation. >=20 > Signed-off-by: Jingjing Wu > --- > doc/guides/rel_notes/deprecation.rst | 4 ---- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 ++++++------ > 2 files changed, 6 insertions(+), 10 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index fffad80..e1a35b9 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -24,10 +24,6 @@ Deprecation Notices > Structures: rte_fdir_*, rte_eth_fdir. > Enums: rte_l4type, rte_iptype. >=20 > -* ABI changes are planned for struct rte_eth_fdir_flow_ext in order to s= upport > - flow director filtering in VF. The release 2.1 does not contain these = ABI > - changes, but release 2.2 will, and no backwards compatibility is plann= ed. > - > * ABI changes are planned for struct rte_eth_fdir_filter and > rte_eth_fdir_masks in order to support new flow director modes, > MAC VLAN and Cloud, on x550. The MAC VLAN mode means the MAC and > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index aa77a91..9a0d18a 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -1624,30 +1624,30 @@ Different NICs may have different capabilities, > command show port fdir (port_id) >=20 > flow_director_filter (port_id) (add|del|update) flow > (ipv4-other|ipv4-frag|ipv6-other|ipv6-frag) > src (src_ip_address) dst (dst_ip_address) vlan (vlan_value) flexbytes > (flexbytes_value) > -(drop|fwd) queue (queue_id) fd_id (fd_id_value) > +(drop|fwd) pf|vf(vf_id) queue (queue_id) fd_id (fd_id_value) >=20 > flow_director_filter (port_id) (add|del|update) flow > (ipv4-tcp|ipv4-udp|ipv6-tcp|ipv6-udp) > src (src_ip_address) (src_port) dst (dst_ip_address) (dst_port) vlan (vl= an_value) > -flexbytes (flexbytes_value) (drop|fwd) queue (queue_id) fd_id (fd_id_val= ue) > +flexbytes (flexbytes_value) (drop|fwd) pf|vf(vf_id) queue (queue_id) > +fd_id (fd_id_value) >=20 > flow_director_filter (port_id) (add|del|update) flow (ipv4-sctp|ipv6-sct= p) src > (src_ip_address) (src_port) dst (dst_ip_address) (dst_port) tag (verifica= tion_tag) > -vlan (vlan_value) flexbytes (flexbytes_value) (drop|fwd) queue (queue_id= ) > fd_id (fd_id_value) > +vlan (vlan_value) flexbytes (flexbytes_value) (drop|fwd) pf|vf(vf_id) > +queue (queue_id) fd_id (fd_id_value) >=20 > flow_director_filter (port_id) (add|del|update) flow l2_payload -ether > (ethertype) flexbytes (flexbytes_value) (drop|fwd) queue (queue_id) fd_id > (fd_id_value) > +ether (ethertype) flexbytes (flexbytes_value) (drop|fwd) pf|vf(vf_id) > +queue (queue_id) fd_id (fd_id_value) >=20 > For example, to add an ipv4-udp flow type filter: >=20 > .. code-block:: console >=20 > - testpmd> flow_director_filter 0 add flow ipv4-udp src 2.2.2.3 32 dst= 2.2.2.5 > 33 vlan 0x1 flexbytes (0x88,0x48) fwd queue 1 fd_id 1 > + testpmd> flow_director_filter 0 add flow ipv4-udp src 2.2.2.3 32 > + dst 2.2.2.5 33 vlan 0x1 flexbytes (0x88,0x48) fwd pf queue 1 fd_id 1 >=20 > For example, add an ipv4-other flow type filter: >=20 > .. code-block:: console >=20 > - testpmd> flow_director_filter 0 add flow ipv4-other src 2.2.2.3 dst = 2.2.2.5 > vlan 0x1 flexbytes (0x88,0x48) fwd queue 1 fd_id 1 > + testpmd> flow_director_filter 0 add flow ipv4-other src 2.2.2.3 dst > + 2.2.2.5 vlan 0x1 flexbytes (0x88,0x48) fwd pf queue 1 fd_id 1 >=20 > flush_flow_director > ~~~~~~~~~~~~~~~~~~~ > -- > 2.4.0