From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 85E455A6B for ; Mon, 2 Nov 2015 08:59:30 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 01 Nov 2015 23:59:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,233,1444719600"; d="scan'208";a="592361355" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2015 23:59:29 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 23:59:29 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 23:59:29 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.194]) by shsmsx102.ccr.corp.intel.com ([169.254.2.253]) with mapi id 14.03.0248.002; Mon, 2 Nov 2015 15:59:27 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration Thread-Index: AQHRExmYX7z/Lhmd+0yA/9qxckzZxJ6H+o5Q///ZBgCAAI5xgA== Date: Mon, 2 Nov 2015 07:59:26 +0000 Message-ID: References: <1446098572-4409-1-git-send-email-helin.zhang@intel.com> <1825895.jnZdLtN9L6@xps13> <3367355.V0LI0AXumx@xps13> In-Reply-To: <3367355.V0LI0AXumx@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 07:59:30 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, November 2, 2015 3:28 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configura= tion >=20 > 2015-11-02 02:11, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-10-30 11:11, Helin Zhang: > > > > v7 changes: > > > > Modified RTE_ETH_INSET_SIZE_MAX from 128 to 1, to avoid ABI changes= . > > > > > > Why it would avoid ABI changes? > > > Have you passed the ABI checker? > > > > Hi Thomas > > > > The only structure modified is ' struct rte_eth_hash_filter_info ', > > where a new element (struct rte_eth_input_set_conf input_set_conf) was > > added. But I kept its structure the same size as another one (struct > > rte_eth_hash_global_conf global_conf) already in that union, they are > > both in 12 bytes. That means nothing changed for ' struct > rte_eth_hash_filter_info'. >=20 > First, it should be justified in the commit message. > Second, I think it's wrong: > The union has struct rte_eth_hash_global_conf =3D enum + uint32_t + uint3= 2_t You > are adding struct rte_eth_input_set_conf =3D uint16_t + uint16_t + enum += enum > I'm not sure we can assume the sizes are the same. Oh, yes, the size might not be the same on all platforms. >=20 > The ethdev ABI is already broken in this release. So maybe we can agree t= hat it's > not a big deal but it should be notified in the release notes and, in thi= s case, you > could keep your original patch with 128 enums. That's bad, but good for me. Can I just enable v6 as 'new', and disable 'v7= '? Or I need a new version? Thank you very much! Helin