From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 134525A92 for ; Tue, 24 Nov 2015 01:33:09 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 23 Nov 2015 16:33:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,338,1444719600"; d="scan'208";a="827554368" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 23 Nov 2015 16:33:10 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 23 Nov 2015 16:33:08 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 23 Nov 2015 16:33:08 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.223]) by shsmsx102.ccr.corp.intel.com ([169.254.2.42]) with mapi id 14.03.0248.002; Tue, 24 Nov 2015 08:33:06 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround Thread-Index: AQHRIQb4L0Vp0YoAkUuRSgz1Ovlmb56psUYAgACrgHA= Date: Tue, 24 Nov 2015 00:33:05 +0000 Message-ID: References: <1447744187-32638-1-git-send-email-helin.zhang@intel.com> <2795108.MCDRmV9y9P@xps13> In-Reply-To: <2795108.MCDRmV9y9P@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 00:33:10 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, November 24, 2015 6:17 AM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround >=20 > 2015-11-17 15:09, Helin Zhang: > > As firmware does not support any link control from software driver > > side, any phy config should be ignored as a workaround. Otherwise the > > link might not be up again after binding back to kernel driver. > > > > Signed-off-by: Helin Zhang > [...] > > +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw, > > + __rte_unused uint8_t abilities, > > + __rte_unused uint8_t force_speed) { > > + /* Skip any phy config on both 10G and 40G interfaces, as a > workaround > > + * for the link control limitation of that all link control should be > > + * handled by firmware. It should follow up if link control will be > > + * opened to software driver in future firmware versions. > > + */ > > return I40E_SUCCESS; > > } >=20 > An error code seems more appropriate. > But I guess you perfectly know what you do, so Applied, thanks Yes, for now, I'd prefer to use I40E_SUCCESS. We will continue working on t= his when firmware provides the link control to sw driver. Thank you very much! Regards, Helin