From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 739BB2EDA for ; Sun, 17 Jan 2016 14:43:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 17 Jan 2016 05:43:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,307,1449561600"; d="scan'208";a="634997405" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jan 2016 05:43:54 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 17 Jan 2016 05:43:53 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 17 Jan 2016 05:43:52 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.215]) with mapi id 14.03.0248.002; Sun, 17 Jan 2016 21:43:50 +0800 From: "Zhang, Helin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 00/29] i40e base driver update Thread-Index: AQHRTz4t/dhAhMrO5kioX/4KuQletp7739uAgAPbk4A= Date: Sun, 17 Jan 2016 13:43:49 +0000 Message-ID: References: <1452825653-623-1-git-send-email-helin.zhang@intel.com> <20160115104811.GB15840@bricha3-MOBL3> In-Reply-To: <20160115104811.GB15840@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 00/29] i40e base driver update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2016 13:43:55 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, January 15, 2016 6:48 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/29] i40e base driver update >=20 > On Fri, Jan 15, 2016 at 10:40:24AM +0800, Helin Zhang wrote: > > i40e base driver is updated, to support new X722 device IDs, and use > > rx control AQ commands to read/write rx control registers. > > Of cause, fixes and enhancements are added as listed as below. > > > > Helin Zhang (29): > > i40e/base: use explicit cast from u16 to u8 > > i40e/base: Acquire NVM, before issuing an AQ read nvm command > > i40e/base: add hw flag for doing the SRCTL access using AQ for X722 > > i40e/base: add changes in nvm read to support X722 > > i40e/base: Limit DCB FW version checks to XL710/X710 devices > > i40e/base: check for stopped admin queue > > i40e/base: set aq count after memory allocation > > i40e/base: clean event descriptor before use > > i40e/base: add new device IDs and delete deprecated one > > i40e/base: fix up recent proxy and wol bits for X722_SUPPORT > > i40e/base: define function capabilities in only one place > > i40e/base: Fix for PHY NVM interaction problem > > i40e/base: set shared bit for multicast filters > > i40e/base: add APIs to Add/remove port mirroring rules > > i40e/base: add VEB stat control and remove L2 cloud filter > > i40e/base: implement the API function for aq_set_switch_config > > i40e/base: Add functions to blink led on Coppervale PHY > > i40e/base: When in promisc mode apply promisc mode to Tx Traffic as > > well > > i40e/base: Increase timeout when checking GLGEN_RSTAT_DEVSTATE bit > > i40e/base: Save off VSI resource count when updating VSI > > i40e/base: coding style fixes > > i40e/base: use FW to read/write rx control registers > > i40e/base: expose some registers to program parser, FD and RSS logic > > i40e/base: Add a Virtchnl offload for RSS PCTYPE V2 > > i40e/base: add AQ thermal sensor control struct > > i40e/base: add/update structure and macro definitions > > i40e: add base driver release info > > i40e: add/remove new device IDs > > i40e: use rx control function for rx control registers >=20 > Couple of minor nits looking through the subject list above. > * the promiscuous mode fix has too long a title, so please shorten (maybe > drop the "when in promisc mode" bit) > * some messages start with a capital letter, others not. They should be > consistent and the standard is to not capitalize. OK, I will have it reworked in the second version. Thanks a lot for the gui= dance! Regards, Helin >=20 > /Bruce