From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B04B037A6 for ; Fri, 18 Mar 2016 01:44:08 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 17 Mar 2016 17:44:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,352,1455004800"; d="scan'208";a="913478221" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 17 Mar 2016 17:44:07 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:44:06 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:44:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 08:43:58 +0800 From: "Zhang, Helin" To: Aaron Conole , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [PATCH 7/8] drivers/net/ixgbe: Signed left shift operator Thread-Index: AQHRb/0vVsRz1PEjQkCCB8us8ylBEJ9efm8w Date: Fri, 18 Mar 2016 00:43:57 +0000 Message-ID: References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-8-git-send-email-aconole@redhat.com> In-Reply-To: <1456426121-21423-8-git-send-email-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWIyNTdhMmUtYjU3YS00ODQ1LTk1OGUtMGIyYTk2NjY3OGIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNZV1NIa1RyYlExdjdoUGtTMDZlbDlnd01tSndPMXA1Q0JVcEJJUmtvWFE9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 7/8] drivers/net/ixgbe: Signed left shift operator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 00:44:09 -0000 > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Helin > ; Ananyev, Konstantin > ; Richardson, Bruce > > Subject: [PATCH 7/8] drivers/net/ixgbe: Signed left shift operator >=20 > Tell the compiler to use an unsigned constant for the config shifts. >=20 > Signed-off-by: Aaron Conole Acked-by: Helin Zhang > --- > drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c = index > 2ffbd1f..8b5119f 100644 > --- a/drivers/net/ixgbe/ixgbe_pf.c > +++ b/drivers/net/ixgbe/ixgbe_pf.c > @@ -236,9 +236,9 @@ int ixgbe_pf_host_configure(struct rte_eth_dev > *eth_dev) > vfre_slot =3D (vf_num >> VFRE_SHIFT) > 0 ? 1 : 0; >=20 > /* Enable pools reserved to PF only */ > - IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot), (~0) << vfre_offset); > + IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot), (~0U) << vfre_offset); > IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot ^ 1), vfre_slot - 1); > - IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0) << vfre_offset); > + IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0U) << vfre_offset); > IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot ^ 1), vfre_slot - 1); >=20 > /* PFDMA Tx General Switch Control Enables VMDQ loopback */ > -- > 2.5.0