From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 94BE22BF9 for ; Fri, 18 Mar 2016 01:45:15 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 17 Mar 2016 17:45:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,352,1455004800"; d="scan'208";a="766469444" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 17 Mar 2016 17:45:15 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:45:14 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 08:45:12 +0800 From: "Zhang, Helin" To: Aaron Conole , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets Thread-Index: AQHRb/0wTsCnvKQ5u0iLEDSvIHwlhp9efsZw Date: Fri, 18 Mar 2016 00:45:12 +0000 Message-ID: References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-6-git-send-email-aconole@redhat.com> In-Reply-To: <1456426121-21423-6-git-send-email-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGJkNzkxMTMtNDAzNS00MWQxLTllNGMtNWQxYmVjYmEzNGEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJWclVBSHdUWDRBNzFhZGNGRHF0Z2syZWIySVJyZEVwbkgzUUFHQmVUems9In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 00:45:16 -0000 > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Helin > ; Ananyev, Konstantin > ; Richardson, Bruce > > Subject: [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets >=20 > The ixgbe vlan filter code has an if check with an incorrect whitespace. >=20 > Signed-off-by: Aaron Conole Acked-by: Helin Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 3e6fe86..2e1c3ad 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4258,10 +4258,11 @@ ixgbe_set_pool_vlan_filter(struct rte_eth_dev *de= v, > uint16_t vlan, > if (ixgbe_vmdq_mode_check(hw) < 0) > return -ENOTSUP; > for (pool_idx =3D 0; pool_idx < ETH_64_POOLS; pool_idx++) { > - if (pool_mask & ((uint64_t)(1ULL << pool_idx))) > + if (pool_mask & ((uint64_t)(1ULL << pool_idx))) { > ret =3D hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on); > if (ret < 0) > return ret; > + } > } >=20 > return ret; > -- > 2.5.0