From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A9DD15588 for ; Fri, 18 Mar 2016 01:56:01 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 17 Mar 2016 17:56:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,352,1455004800"; d="scan'208";a="671587470" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 17 Mar 2016 17:56:00 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 17:56:00 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 08:55:58 +0800 From: "Zhang, Helin" To: Aaron Conole , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [PATCH 4/8] drivers/net/e1000: Fix missing lsc interrupt check brackets Thread-Index: AQHRb/0sRO1JXAvne0OZpoUpobp4m59egaoQ Date: Fri, 18 Mar 2016 00:55:57 +0000 Message-ID: References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-5-git-send-email-aconole@redhat.com> In-Reply-To: <1456426121-21423-5-git-send-email-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2YxZjY3ZDQtZjQ3NS00NTY0LTgxYzktYjM4NGFlNTZlODQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJ0V0wxTVhOcW55VFhpVFp5MTRcL0J6QmdDeHZFbnh4QnVUMUJjMytEUGY4PSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/8] drivers/net/e1000: Fix missing lsc interrupt check brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 00:56:02 -0000 > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Helin > ; Ananyev, Konstantin > ; Richardson, Bruce > > Subject: [PATCH 4/8] drivers/net/e1000: Fix missing lsc interrupt check b= rackets >=20 > The device lsc interupt check has a misleading whitespace around it which= can be > improved by adding appropriate braces to the check. Since the ret variabl= e was > checked after previous assignment, this introduces no functional change. It seems a "Fixes: " line is required. >=20 > Signed-off-by: Aaron Conole > --- > drivers/net/e1000/em_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.= c > index 4a843fe..1d86091 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -637,13 +637,14 @@ eth_em_start(struct rte_eth_dev *dev) >=20 > if (rte_intr_allow_others(intr_handle)) { > /* check if lsc interrupt is enabled */ > - if (dev->data->dev_conf.intr_conf.lsc !=3D 0) > + if (dev->data->dev_conf.intr_conf.lsc !=3D 0) { > ret =3D eth_em_interrupt_setup(dev); > if (ret) { > PMD_INIT_LOG(ERR, "Unable to setup interrupts"); > em_dev_clear_queues(dev); > return ret; > } > + } > } else { > rte_intr_callback_unregister(intr_handle, > eth_em_interrupt_handler, > -- > 2.5.0