From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A209C56A2 for ; Fri, 18 Mar 2016 02:05:58 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 17 Mar 2016 18:05:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,352,1455004800"; d="scan'208";a="671592597" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 17 Mar 2016 18:05:57 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Mar 2016 18:05:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Fri, 18 Mar 2016 09:05:55 +0800 From: "Zhang, Helin" To: Aaron Conole , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [PATCH 2/8] app/test/test: Fix missing brackets Thread-Index: AQHRb/0tMD6Hbg4DYE2SWREvspsb5p9ehJKg Date: Fri, 18 Mar 2016 01:05:55 +0000 Message-ID: References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-3-git-send-email-aconole@redhat.com> In-Reply-To: <1456426121-21423-3-git-send-email-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGRmYjAwNDgtMjFmOS00MGE4LWJkODItYmQ2YjY3NTVmOWQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJHMmdUZlRPVTVWSER1V2w2MWhJUlM4VThjRFVsXC81WGIrajFTdDdmMFowPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/8] app/test/test: Fix missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 01:05:59 -0000 > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Helin > ; Ananyev, Konstantin > ; Richardson, Bruce > > Subject: [PATCH 2/8] app/test/test: Fix missing brackets >=20 > The test application calls printf(...) with the suite->suite_name argumen= t. > The intent (based on whitespace) in the printf is to check suite->suite_n= ame first > and then apply the printf. This doesn't happen due to missing brackets. >=20 > Signed-off-by: Aaron Conole Acked-by: Helin Zhang > --- > app/test/test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test.c b/app/test/test.c index f35b304..ccad0e3 100= 644 > --- a/app/test/test.c > +++ b/app/test/test.c > @@ -162,9 +162,10 @@ unit_test_suite_runner(struct unit_test_suite *suite= ) > int test_success; > unsigned total =3D 0, executed =3D 0, skipped =3D 0, succeeded =3D 0, f= ailed =3D 0; >=20 > - if (suite->suite_name) > + if (suite->suite_name) { > printf(" + ------------------------------------------------------- +\n= "); > printf(" + Test Suite : %s\n", suite->suite_name); > + } >=20 > if (suite->setup) > if (suite->setup() !=3D 0) > -- > 2.5.0