From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <helin.zhang@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 465FC37B2 for <dev@dpdk.org>; Tue, 19 Apr 2016 04:32:02 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 18 Apr 2016 19:32:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,504,1455004800"; d="scan'208";a="948044879" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 18 Apr 2016 19:32:01 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Apr 2016 19:32:00 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Apr 2016 19:32:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Tue, 19 Apr 2016 10:31:58 +0800 From: "Zhang, Helin" <helin.zhang@intel.com> To: "Topel, Bjorn" <bjorn.topel@intel.com>, David Marchand <david.marchand@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com> Thread-Topic: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for Linux PF hosts Thread-Index: AQHRluo15ITjA8gZqUawlBVwJ8mUU5+KrYwggATj+gCAAQfD4A== Date: Tue, 19 Apr 2016 02:31:58 +0000 Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70AA1051C@SHSMSX103.ccr.corp.intel.com> References: <1460645904-19565-1-git-send-email-bjorn.topel@intel.com> <CALwxeUsmicWrmCtEY+8Qy-eySTaatS9_CVMbdG0U-Z9OfytgdQ@mail.gmail.com>, <F35DEAC7BCE34641BA9FAC6BCA4A12E70AA06695@SHSMSX104.ccr.corp.intel.com> <6B5F13689D63284BBB0B66A5B315C82DBAAD8C@IRSMSX103.ger.corp.intel.com> In-Reply-To: <6B5F13689D63284BBB0B66A5B315C82DBAAD8C@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE0NGEzZDMtZjFiNC00NTBmLTg1YWQtZThmN2Y1Nzg1ZjkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjczanVSSEMxYm45bGFQdFJcL0p5SG8zVzVVVDEwU1E2RDhMbWxnakpIY3l3PSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for Linux PF hosts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 19 Apr 2016 02:32:02 -0000 > -----Original Message----- > From: Topel, Bjorn > Sent: Tuesday, April 19, 2016 2:47 AM > To: Zhang, Helin <helin.zhang@intel.com>; David Marchand > <david.marchand@6wind.com> > Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com> > Subject: RE: [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip for = Linux PF > hosts >=20 > >> Not sure this is the right way to handle it. The driver should > >> return an error rather than silently discard what the application > >> asked. > > > > I also think it should return an error with checking if the host is > > kernel driver, and crc strip is disabled in VF. Thank you David! >=20 > Thanks for reviewing my patch, Helin and David. >=20 > I agree that it's subtle to ignore the error, and just log the error. Thi= s is how > ixgbevf behaves (refer to ixgbevf_dev_configure), so I figured that i40ev= f should > behave analogous. >=20 > I'll submit a v2 of the patch that returns an EINVAL and logs the failure= . >=20 > Would it make sense to change the ixgbevf_dev_configure as well, in a sep= arate > patch? Yes, I agree with you that ixgbe and i40e should be consistent. Thank you! /Helin >=20 >=20 > >> --------------------------------------------------------------------- > >> - > >> Intel Sweden AB > >> Registered Office: Isafjordsgatan 30B, 164 40 Kista, Stockholm, > >> Sweden Registration Number: 556189-6027 > >> > >> This e-mail and any attachments may contain confidential material for > >> the sole use of the intended recipient(s). Any review or distribution > >> by others is strictly prohibited. If you are not the intended > >> recipient, please contact the sender and delete all copies. > > > > Please, remove this. >=20 > Noted. Will make sure to fix that for future revisions. Thanks! >=20 >=20 > Bj=F6rn