From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 926CB2E83
 for <dev@dpdk.org>; Fri, 22 Apr 2016 07:07:23 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 21 Apr 2016 22:07:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,516,1455004800"; d="scan'208";a="89778647"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2016 22:07:22 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 21 Apr 2016 22:07:22 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002;
 Fri, 22 Apr 2016 13:07:20 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Topel, Bjorn" <bjorn.topel@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "david.marchand@6wind.com" <david.marchand@6wind.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
Thread-Topic: [PATCH v2] i40evf: Report error if HW CRC strip is disabled
 for Linux PF hosts
Thread-Index: AQHRm98HnmjO5tNGZEOzA6A+xdg8e5+VOwZw//+tW4CAAIgP4A==
Date: Fri, 22 Apr 2016 05:07:20 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70AA1235E@SHSMSX103.ccr.corp.intel.com>
References: <1460645904-19565-1-git-send-email-bjorn.topel@intel.com>
 <1461250975-14437-1-git-send-email-bjorn.topel@intel.com>,
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70AA12288@SHSMSX103.ccr.corp.intel.com>
 <6B5F13689D63284BBB0B66A5B315C82DBAC5E2@IRSMSX103.ger.corp.intel.com>
In-Reply-To: <6B5F13689D63284BBB0B66A5B315C82DBAC5E2@IRSMSX103.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is
 disabled for Linux PF hosts
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Apr 2016 05:07:24 -0000


> -----Original Message-----
> From: Topel, Bjorn
> Sent: Friday, April 22, 2016 12:55 PM
> To: Zhang, Helin; dev@dpdk.org
> Cc: david.marchand@6wind.com; Wu, Jingjing
> Subject: RE: [PATCH v2] i40evf: Report error if HW CRC strip is disabled =
for
> Linux PF hosts
>=20
> >> +     /* For Linux PF hosts, VF has no ability to disable HW CRC strip=
,
> >> +      * and is implicitly enabled by the PF.
> >> +      */
> >> +     if (!conf->rxmode.hw_strip_crc) {
> >> +             vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
> >> +             if ((vf->version_major =3D=3D I40E_VIRTCHNL_VERSION_MAJO=
R) &&
> >> +                 (vf->version_minor <=3D I40E_VIRTCHNL_VERSION_MINOR)=
) {
> >> +                     /* Peer is Linux PF host. */
> > Can you reword above comments?
> > It just means the host is not DPDK PF host driver, it could be Linux
> > driver, and possible others (e.g. FreeBSD, VMWARE?).
>=20
> Sure, I'll reword it! The broader question, however, is this correct for =
non-
> Linux/non-DPDK PF drivers?
> For FreeBSD I'll dig into the code, but for VMWARE (and I'd assume Micros=
oft
> Windows) it'll be harder.
>=20
> Do you have any insights on the behavior for the non-open i40e PF drivers=
?
>=20
> From the documentation [1], it's unclear whether non-Linux/non-DPDK PF
> drivers are supported. My interpretation was that only DPDK and Linux PF
> hosts are supported for Fortville NICs.
I guess only DPDK is different, though I am not sure.
As all other NIC drivers were developped by the same organization.
Even assuming that FreeBSD supports both configuration, it will not be a pr=
oblem,
as DPDK just doesn't support, and nothing wrong.

Thanks,
Helin

>=20
>=20
> Bj=F6rn
>=20
>=20
> [1] http://dpdk.org/doc/guides/nics/intel_vf.html