From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7DFA311C5 for ; Wed, 27 Apr 2016 08:30:31 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 26 Apr 2016 23:30:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,540,1455004800"; d="scan'208";a="941084339" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 26 Apr 2016 23:30:29 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 26 Apr 2016 23:30:28 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 26 Apr 2016 23:30:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by shsmsx102.ccr.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0248.002; Wed, 27 Apr 2016 14:30:25 +0800 From: "Zhang, Helin" To: "Mrzyglod, DanielX T" , "Chen, Jing D" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] i40e: dereference before null check Thread-Index: AQHRmY08CpOQSUU6nUKhph+PjL3KkZ+daVYw Date: Wed, 27 Apr 2016 06:30:26 +0000 Message-ID: References: <1460998153-187871-1-git-send-email-danielx.t.mrzyglod@intel.com> <1460999603-188184-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1460999603-188184-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2016 06:30:31 -0000 > -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Tuesday, April 19, 2016 1:13 AM > To: Chen, Jing D; Wu, Jingjing; Zhang, Helin > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH v2] i40e: dereference before null check >=20 > Fix issue reported by Coverity. > Coverity ID 13302: > There may be a null pointer dereference, or else the comparison against n= ull > is unnecessary. >=20 > In i40evf_config_vlan_pvid: All paths that lead to this null pointer comp= arison > already dereference the pointer earlier >=20 > Fixes: 2b12431b5369 ("i40e: add vlan stripping and insertion to VF") >=20 > Signed-off-by: Daniel Mrzyglod Acked-by: Helin Zhang