From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4C2FB952
 for <dev@dpdk.org>; Mon, 11 Jul 2016 09:03:13 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 11 Jul 2016 00:03:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="1004423643"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by fmsmga001.fm.intel.com with ESMTP; 11 Jul 2016 00:02:17 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 11 Jul 2016 00:02:17 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002;
 Mon, 11 Jul 2016 15:02:15 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] i40e: move PCI device ids to driver
Thread-Index: AQHR2yjqkivjGY/yC0urJgdixfXEfKASwYtw//+EbACAAIbAsA==
Date: Mon, 11 Jul 2016 07:02:15 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E717D95497@SHSMSX103.ccr.corp.intel.com>
References: <1468209673-21685-1-git-send-email-jingjing.wu@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E717D953B3@SHSMSX103.ccr.corp.intel.com>
 <2755332.bbWM3o0Z6X@xps13>
In-Reply-To: <2755332.bbWM3o0Z6X@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] i40e: move PCI device ids to driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2016 07:03:13 -0000

Hi Thomas

It should be the one from David as I read that before. I am not sure if all=
 PMD has its own header files for device IDs, but I did see there was.
Even in recent kernel drivers (e.g. i40e), there is a new header file for d=
evice ID list. I think it could be clearer, though no correct or wrong.

Regards,
Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, July 11, 2016 2:55 PM
> To: Zhang, Helin
> Cc: Wu, Jingjing; dev@dpdk.org
> Subject: Re: [PATCH] i40e: move PCI device ids to driver
>=20
> Hi Helin,
>=20
> 2016-07-11 06:19, Zhang, Helin:
> > Hi Jingjing
> >
> > I'd suggest to add a new header file in each PMD to define what we defi=
ned
> in rte_pci_dev_ids.h.
>=20
> Why?
>=20
> > There was a patch set submitted several months ago, like that.
>=20
> Which one?