From: "Zhang, Helin" <helin.zhang@intel.com>
To: caihe <caihe@huawei.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
wangyunjian <wangyunjian@huawei.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
Zhoujingbin <zhoujingbin@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e: check return value of rte_zmalloc
Date: Tue, 28 Mar 2017 01:29:27 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AA2A679@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <453363AE6316CC428D594009B784F9050335F139@SZXEMI508-MBS.china.huawei.com>
Hi Cai He
Yes, I agree with you.
Please rework your patch, and send out another version. Thank you very much for the good catch!
Regards,
Helin
> -----Original Message-----
> From: caihe [mailto:caihe@huawei.com]
> Sent: Saturday, March 25, 2017 8:30 PM
> To: Zhang, Helin <helin.zhang@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; wangyunjian <wangyunjian@huawei.com>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; Zhoujingbin <zhoujingbin@huawei.com>
> Subject: [dpdk-dev] [PATCH 1/1] net/i40e: check return value of rte_zmalloc
I think it can be a bug fix, so please start with 'fix' in the title.
>
> Hi helin,
>
> There is a bug without check the return value of alloc memory in function i40evf_add_del_all_mac_addr, if we should fix it as below:
Please describe the issue with more details.
'Signoff' line is needed, please use 'git format --signoff <>' to generate the patches.
'Fix' line is also needed, as it is a bug fix. Please refer to other fix commit for more details.
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index 55fd344..37ea7ac 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2014,6 +2014,11 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,
> }
>
> list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
> + if (!list) {
> + PMD_DRV_LOG(ERR, "fail to alloc memory, abort execute command %s",
> + add ? "OP_ADD_ETHER_ADDRESS" : "OP_DEL_ETHER_ADDRESS");
> + return;
> + }
>
> for (i = begin; i < next_begin; i++) {
> addr = &dev->data->mac_addrs[i];
>
> Best Regards
prev parent reply other threads:[~2017-03-28 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 12:30 caihe
2017-03-27 11:00 ` Ferruh Yigit
2017-03-28 1:29 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AA2A679@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=caihe@huawei.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=jingjing.wu@intel.com \
--cc=wangyunjian@huawei.com \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).