From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Peters, Matt (Wind River)" <matt.peters@windriver.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: mbuf alloc failed counter not incremented
Date: Tue, 28 Mar 2017 08:52:23 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AA2BF55@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170327163035.76744-1-allain.legacy@windriver.com>
> -----Original Message-----
> From: Allain Legacy [mailto:allain.legacy@windriver.com]
> Sent: Tuesday, March 28, 2017 12:31 AM
> To: Zhang, Helin; Wu, Jingjing
> Cc: dev@dpdk.org; Peters, Matt (Wind River)
> Subject: [PATCH] net/i40e: mbuf alloc failed counter not incremented
>
> From: Matt Peters <matt.peters@windriver.com>
>
> When an mbuf alloc fails during the mempool get operation for the i40e bulk
> alloc receive function, the rx_mbuf_alloc_failed counter is not incremented to
> record the error.
>
> This fix ensures consistency with the other i40e receive procedures and other
> net drivers.
>
> Signed-off-by: Matt Peters <matt.peters@windriver.com>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> ec64a20eb..794d8717e 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -610,6 +610,7 @@ static inline uint16_t rx_recv_pkts(void *rx_queue,
> struct rte_mbuf **rx_pkts, uint16_t nb_pkts) {
> struct i40e_rx_queue *rxq = (struct i40e_rx_queue *)rx_queue;
> + struct rte_eth_dev *dev;
> uint16_t nb_rx = 0;
>
> if (!nb_pkts)
> @@ -630,6 +631,10 @@ rx_recv_pkts(void *rx_queue, struct rte_mbuf
> **rx_pkts, uint16_t nb_pkts)
> PMD_RX_LOG(DEBUG, "Rx mbuf alloc failed for "
> "port_id=%u, queue_id=%u",
> rxq->port_id, rxq->queue_id);
> +
> + dev = &rte_eth_devices[rxq->port_id];
> + dev->data->rx_mbuf_alloc_failed += rxq-
> >rx_free_thresh;
> +
I think there are more places to have the similar code. Would you help to complete all?
e.g. rte_mbuf_raw_alloc() in i40e_recv_pkts.
Thank you very much for the helps!
/Helin
> rxq->rx_nb_avail = 0;
> rxq->rx_tail = (uint16_t)(rxq->rx_tail - nb_rx);
> for (i = 0, j = rxq->rx_tail; i < nb_rx; i++, j++)
> --
> 2.12.1
next prev parent reply other threads:[~2017-03-28 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:30 Allain Legacy
2017-03-28 8:52 ` Zhang, Helin [this message]
2017-03-29 22:42 ` Legacy, Allain
2017-04-21 23:13 ` [dpdk-dev] [PATCH v2] " Allain Legacy
2017-04-24 5:46 ` Ferruh Yigit
2017-04-24 11:21 ` Legacy, Allain
2017-04-25 11:01 ` Zhang, Helin
2017-04-25 12:28 ` [dpdk-dev] [PATCH v3] " Allain Legacy
2017-04-25 17:31 ` Zhang, Helin
2017-04-26 8:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AA2BF55@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=matt.peters@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).