From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 52DEEFE5 for ; Fri, 31 Mar 2017 09:33:51 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 31 Mar 2017 00:33:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="82612511" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 31 Mar 2017 00:33:50 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 31 Mar 2017 00:33:50 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 31 Mar 2017 00:33:50 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.82]) with mapi id 14.03.0248.002; Fri, 31 Mar 2017 15:33:46 +0800 From: "Zhang, Helin" To: Thomas Monjalon , Yongseok Koh , "Yigit, Ferruh" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" Thread-Topic: [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size Thread-Index: AQHSqO3eiWTjDjZYnECNHaBxCiFjZqGukCTQ Date: Fri, 31 Mar 2017 07:33:45 +0000 Message-ID: References: <20170316224056.19685-1-yskoh@mellanox.com> <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com> <1920337.9E3jvcbJyk@xps13> In-Reply-To: <1920337.9E3jvcbJyk@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 07:33:52 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, March 30, 2017 8:38 AM > To: Yongseok Koh; Yigit, Ferruh; Zhang, Helin; Ananyev, Konstantin > Cc: dev@dpdk.org; adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com > Subject: Re: [PATCH v2 1/3] lib/librte_ether: remove requirement of align= ed > RETA size >=20 > 2017-03-20 16:04, Yongseok Koh: > > In rte_eth_check_reta_mask(), it is required to align the size of the > > RETA table to RTE_RETA_GROUP_SIZE but as the size can be less than the > > limit, this should be removed. The change is also applied to a command = of > testpmd. > > > > Signed-off-by: Yongseok Koh > [...] > > - if (reta_size !=3D RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) { > > - RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u > aligned\n", > > - > RTE_RETA_GROUP_SIZE); > > - return -EINVAL; > > - } > > - > > - num =3D reta_size / RTE_RETA_GROUP_SIZE; > > + num =3D (reta_size + RTE_RETA_GROUP_SIZE - 1) / > RTE_RETA_GROUP_SIZE; >=20 > There is no comment for this constraint neither in the code nor in the > commit: http://dpdk.org/commit/66c594904 So, I guess it can be removed. > If a check is needed, it could be added in the relevant drivers. >=20 > Helin, Konstantin, please check for Intel drivers. Hi Thomas Thank you very much for the reminder! We will check that and see if there is any impacts to Intel drivers. Regards, Helin >=20 > Ferruh, please take care of this series.