From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BD3CF1C00 for ; Thu, 11 May 2017 03:04:09 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 18:04:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,322,1491289200"; d="scan'208";a="1167438230" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2017 18:04:08 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 May 2017 18:04:07 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 May 2017 18:04:07 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Thu, 11 May 2017 09:04:05 +0800 From: "Zhang, Helin" To: "Lipiec, Herakliusz" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [DPDK] net/i40e: add return value checks Thread-Index: AQHSyM/gv1AmUJs7CkOcoVzJVKaHaKHuUztw Date: Thu, 11 May 2017 01:04:05 +0000 Message-ID: References: <1494340654-29221-1-git-send-email-herakliusz.lipiec@intel.com> In-Reply-To: <1494340654-29221-1-git-send-email-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] net/i40e: add return value checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 01:04:10 -0000 > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Tuesday, May 9, 2017 10:38 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev@dpdk.org > Subject: [DPDK] net/i40e: add return value checks >=20 > Coverity issue: 1379362 > Coverity issue: 1379365 > Fixes: 71d35259ff67 ("i40e: tear down flow director") >=20 > Signed-off-by: Herakliusz Lipiec Acked-by: Helin Zhang > --- > drivers/net/i40e/i40e_fdir.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > 28cc554..b8cfa0f 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -300,8 +300,12 @@ i40e_fdir_teardown(struct i40e_pf *pf) > vsi =3D pf->fdir.fdir_vsi; > if (!vsi) > return; > - i40e_switch_tx_queue(hw, vsi->base_queue, FALSE); > - i40e_switch_rx_queue(hw, vsi->base_queue, FALSE); > + int err =3D i40e_switch_tx_queue(hw, vsi->base_queue, FALSE); > + if (err) > + PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off"); > + err =3D i40e_switch_rx_queue(hw, vsi->base_queue, FALSE); > + if (err) > + PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off"); > i40e_dev_rx_queue_release(pf->fdir.rxq); > pf->fdir.rxq =3D NULL; > i40e_dev_tx_queue_release(pf->fdir.txq); > -- > 2.7.4