From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ADE612C16 for ; Mon, 18 Dec 2017 04:05:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2017 19:05:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,419,1508828400"; d="scan'208";a="3328514" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 17 Dec 2017 19:05:28 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 17 Dec 2017 19:05:28 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 17 Dec 2017 19:05:28 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Mon, 18 Dec 2017 11:05:26 +0800 From: "Zhang, Helin" To: "Wu, Yanglong" , "Xing, Beilei" , "Zhang, Qi Z" , "Wu, Jingjing" CC: "Wu, Yanglong" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: i40e support mac loopback Thread-Index: AQHTYbTqdqzsTl7lAkeH3/Ezk4cVpqNIlecA Date: Mon, 18 Dec 2017 03:05:26 +0000 Message-ID: References: <20171120040531.152695-1-yanglong.wu@intel.com> In-Reply-To: <20171120040531.152695-1-yanglong.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: i40e support mac loopback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 03:05:30 -0000 Hi Yanglong It seems your patch cannot be applied on my system. Please do a check on yo= ur patch. In addition, please make sure your local git repo was cloned from the right= sub-tree. e.g. 'git clone http://dpdk.org/git/next/dpdk-next-net-intel' Hi maintainers I need your comments, ACK or NACK. Thanks! Regards, Helin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, November 20, 2017 12:06 PM > To: dev@dpdk.org > Cc: Wu, Yanglong > Subject: [dpdk-dev] [PATCH] net/i40e: i40e support mac loopback >=20 > According to loopback mode, setup loopback link or not. > If loopback link is setted, packets will be sent to rx_q from tx_q > directly.Loopback mode can be used to support testing task. >=20 > Signed-off-by: Yanglong Wu > --- > drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + > drivers/net/i40e/i40e_ethdev.c | 12 +++++++++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h > b/drivers/net/i40e/base/i40e_adminq_cmd.h > index c36da2a32..8171f877b 100644 > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h > @@ -2128,6 +2128,7 @@ > I40E_CHECK_CMD_LENGTH(i40e_aqc_an_advt_reg); > /* Set Loopback mode (0x0618) */ > struct i40e_aqc_set_lb_mode { > __le16 lb_mode; > +#define I40E_AQ_LB_MODE_NONE 0x0 > #define I40E_AQ_LB_PHY_LOCAL 0x01 > #define I40E_AQ_LB_PHY_REMOTE 0x02 > #define I40E_AQ_LB_MAC_LOCAL 0x04 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index f40c463aa..2e6aa9d0d 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2048,6 +2048,17 @@ i40e_dev_start(struct rte_eth_dev *dev) > } > } >=20 > + /* Enable mac loopback mode */ > + if (hw->mac.type =3D=3D I40E_MAC_XL710 && > + (dev->data->dev_conf.lpbk_mode =3D=3D I40E_AQ_LB_MODE_NONE || > + dev->data->dev_conf.lpbk_mode =3D=3D > I40E_AQ_LB_PHY_LOCAL)) { > + ret =3D i40e_aq_set_lb_modes(hw, > + dev->data->dev_conf.lpbk_mode, > NULL); > + if (ret !=3D I40E_SUCCESS) { > + PMD_DRV_LOG(INFO, "fail to set loopback link"); > + goto err_up; > + } > + } > + > /* Apply link configure */ > if (dev->data->dev_conf.link_speeds & ~(ETH_LINK_SPEED_100M | > ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G > | > -- > 2.11.0