From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>
Cc: "Wu, Yanglong" <yanglong.wu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF
Date: Sun, 7 Jan 2018 15:34:22 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACE5CE3@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772585FABEAA2@irsmsx105.ger.corp.intel.com>
Hi Yanglong
Please follow the comments, and get all of them well addressed.
My comments is you need to use in-reply-to when you send any
updated versions of a patch.
Regards,
Helin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev,
> Konstantin
> Sent: Monday, November 20, 2017 6:44 PM
> To: Wu, Yanglong; dev@dpdk.org
> Cc: Wu, Yanglong
> Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> > Sent: Monday, November 20, 2017 2:40 AM
> > To: dev@dpdk.org
> > Cc: Wu, Yanglong <yanglong.wu@intel.com>
> > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF
> >
> > L3fwd start failed on PF, for tx_q check failed.
> > That occurred when the SRIOV is active and tx_q > rx_q.
> > The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool should
> > equeal to max number of queues supported by HW not nb_rx_q.
> >
> > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to
> > specific drivers)
> >
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ae9c44421..0f0641da1 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev
> *dev, uint16_t nb_rx_q)
> > return -EINVAL;
> > }
> >
> > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
> > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 128 /
> > +RTE_ETH_DEV_SRIOV(dev).active;
>
> Please use appropriate macros instead of constants
> (s/128/IXGBE_MAX_RX_QUEUE_NUM).
>
>
> > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs *
> nb_rx_q;
>
>
> Shouldn't we also change that line to:
> RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs *
> RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> ?
>
> Konstantin
>
> >
> > return 0;
> > --
> > 2.11.0
next prev parent reply other threads:[~2018-01-07 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171102161031.167892-2-yanglong.wu@intel.com>
2017-11-20 1:53 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2017-11-20 2:29 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2017-11-20 2:40 ` [dpdk-dev] [PATCH v4] " Yanglong Wu
2017-11-20 10:43 ` Ananyev, Konstantin
2017-11-21 2:17 ` Wu, Yanglong
2018-01-07 15:34 ` Zhang, Helin [this message]
2018-01-08 3:06 ` [dpdk-dev] [PATCH v5] net/ixgbe: fix l3fwd start failed on Yanglong Wu
2018-01-08 11:54 ` Ananyev, Konstantin
2018-01-09 2:29 ` Wu, Yanglong
2018-01-09 12:39 ` Ananyev, Konstantin
2018-01-10 1:51 ` [dpdk-dev] [PATCH v6] net/ixgbe: fix tx_q check failed on PF Yanglong Wu
2018-01-10 1:57 ` Ananyev, Konstantin
2018-01-10 2:23 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACE5CE3@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).