From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0540E2BF5 for ; Sun, 7 Jan 2018 16:34:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2018 07:34:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,326,1511856000"; d="scan'208";a="164852599" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 07 Jan 2018 07:34:25 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 07:34:25 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 07:34:24 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Sun, 7 Jan 2018 23:34:22 +0800 From: "Zhang, Helin" To: "Wu, Yanglong" CC: "Wu, Yanglong" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF Thread-Index: AQHTYakOXjGBbbmZpkinhfpWL5hR16MdFCcQgEvCKAA= Date: Sun, 7 Jan 2018 15:34:22 +0000 Message-ID: References: <20171120022951.151510-1-yanglong.wu@intel.com> <20171120024026.152048-1-yanglong.wu@intel.com> <2601191342CEEE43887BDE71AB9772585FABEAA2@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FABEAA2@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 15:34:27 -0000 Hi Yanglong Please follow the comments, and get all of them well addressed. My comments is you need to use in-reply-to when you send any updated versions of a patch. Regards, Helin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Monday, November 20, 2017 6:44 PM > To: Wu, Yanglong; dev@dpdk.org > Cc: Wu, Yanglong > Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on P= F >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > > Sent: Monday, November 20, 2017 2:40 AM > > To: dev@dpdk.org > > Cc: Wu, Yanglong > > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF > > > > L3fwd start failed on PF, for tx_q check failed. > > That occurred when the SRIOV is active and tx_q > rx_q. > > The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool should > > equeal to max number of queues supported by HW not nb_rx_q. > > > > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to > > specific drivers) > > > > Signed-off-by: Yanglong Wu > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index ae9c44421..0f0641da1 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev > *dev, uint16_t nb_rx_q) > > return -EINVAL; > > } > > > > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D nb_rx_q; > > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 128 / > > +RTE_ETH_DEV_SRIOV(dev).active; >=20 > Please use appropriate macros instead of constants > (s/128/IXGBE_MAX_RX_QUEUE_NUM). >=20 >=20 > > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * > nb_rx_q; >=20 >=20 > Shouldn't we also change that line to: > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool; > ? >=20 > Konstantin >=20 > > > > return 0; > > -- > > 2.11.0