From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CEE053250 for ; Sun, 7 Jan 2018 16:43:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2018 07:43:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,326,1511856000"; d="scan'208";a="8798239" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 07 Jan 2018 07:43:28 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 07:43:28 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 Jan 2018 07:43:27 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Sun, 7 Jan 2018 23:43:25 +0800 From: "Zhang, Helin" To: "Zhang, Qi Z" , "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API Thread-Index: AQHTZQFrY5qsfVj6Q0y2ZNAQGpW8P6NO7FXAgBnlzBA= Date: Sun, 7 Jan 2018 15:43:25 +0000 Message-ID: References: <20171124084312.57832-1-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E7061153123DE8@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153123DE8@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 15:43:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, December 22, 2017 12:36 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: Zhao1, Wei > Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API >=20 > Hi Wei: >=20 > Please check my comment below. > Besides, there some line over 80 character warning need to fix >=20 > Regards > Qi >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > > Sent: Friday, November 24, 2017 4:43 PM > > To: dev@dpdk.org > > Cc: Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API > > > > Rte_flow actually defined to include RSS, but till now, RSS is out of r= te_flow. > > This patch is to move i40e existing RSS to rte_flow. > > This patch also enable queue region configuration using flow API for i4= 0e. > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_ethdev.c | 91 +++++++++++ > > drivers/net/i40e/i40e_ethdev.h | 11 ++ > > drivers/net/i40e/i40e_flow.c | 336 > > +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 438 insertions(+) Have you addressed all the comments? Did I miss anything? In addition, I think doc update is needed. e.g. doc/nics/i40e.rst or simila= r? Thanks, Helin