[dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem

[dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem

[Wei Zhao]

Add a mode type check for tunnel mode, if fdir is
in this mode, it do not need to do Sanity check for x550.

Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 9281dc1..c117647 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1277,7 +1277,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 	     IXGBE_ATR_FLOW_TYPE_IPV6) &&
 	    (info->mask.src_port_mask != 0 ||
 	     info->mask.dst_port_mask != 0) &&
-	     rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+	    (rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN &&
+	     rule->mode != RTE_FDIR_MODE_PERFECT_TUNNEL)) {
 		PMD_DRV_LOG(ERR, "By this device,"
 			    " IPv4 is not supported without"
 			    " L4 protocol and ports masked!");
-- 
2.7.5

Re: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem

[Lu, Wenzhuo]

Hi Wei,


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Friday, November 17, 2017 1:36 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel filter fail problem
> 
> Add a mode type check for tunnel mode, if fdir is in this mode, it do not
> need to do Sanity check for x550.
> 
> Fixes: dc0c16105d2d2 ("ixgbe: fix X550 flow director check")
The patch is good, but seems the fixes tag is not right. This fix should be for some patch newer than this one.

> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Wei Zhao]

Add a mode type check for tunnel mode, if fdir is
in this mode, it do not need to do Sanity check for x550.

Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change fix code version hash code.
---
 drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 9281dc1..c117647 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1277,7 +1277,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 	     IXGBE_ATR_FLOW_TYPE_IPV6) &&
 	    (info->mask.src_port_mask != 0 ||
 	     info->mask.dst_port_mask != 0) &&
-	     rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+	    (rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN &&
+	     rule->mode != RTE_FDIR_MODE_PERFECT_TUNNEL)) {
 		PMD_DRV_LOG(ERR, "By this device,"
 			    " IPv4 is not supported without"
 			    " L4 protocol and ports masked!");
-- 
2.9.3

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Lu, Wenzhuo]

Hi,

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:36 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> 
> Add a mode type check for tunnel mode, if fdir is in this mode, it do not
> need to do Sanity check for x550.
> 
> Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Monday, January 8, 2018 1:09 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> 
> Hi,
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:36 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> >
> > Add a mode type check for tunnel mode, if fdir is in this mode, it do
> > not need to do Sanity check for x550.
> >
> > Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin